Plz help me with my counter code

[Anon]

Hi

I am trying to make a text file increase everytime the page is run.

When i load the page though, i get the followig error:

Warning: Unable to find file identifier 0 in /usr/users1/nbscan/public_html/order4.php3 on line 93

Can someone help me please?

Thanks
Ben

<?
$refFile = "/usr/users1/nbscan/public_html/data/refs.count";
$fpr = fopen($refFile,rw);

$numr = fgets($fp,5);

$numr = +1;

print "$numr";

exec( "rm -rf $refFile");

exec( "echo $numr > $refFile");

?>

[Anon]

Try using this code...its a simple function called counthits, that keeps track of page hits, using text file manipulation:

<?php
function counthits($file) {
$fd = fopen($file,"r");
$count = fgets($fd,1024);
fclose($fd);
$count=((int)$count)+1;
$fd = fopen($file,"w");
fwrite($fd,"$count\n");
fclose($fd);
return $count;
}

and then....

echo "This page has been accessed "
. counthits('somefile....') . " times.\n";
?>

Hope this helps.

[Anon]

Try using this code...its a simple function called counthits, that keeps track of page hits, using text file manipulation:

<?php
function counthits($file) {
$fd = fopen($file,"r");
$count = fgets($fd,1024);
fclose($fd);
$count=((int)$count)+1;
$fd = fopen($file,"w");
fwrite($fd,"$count\n");
fclose($fd);
return $count;
}

and then....

echo "This page has been accessed "
. counthits('somefile....') . " times.\n";
?>

Hope this helps.

[Anon]

   $fpr     = fopen($refFile,rw);  

you are using $fpr on this line and $fp in line below !!!!
also you are not checking for error codes
if (!$fpr) {
echo 'error!'
exit;
}

   $numr    = fgets($fp,5);  

you are using different variables

   $numr    = +1;  

$numr++;

   exec( "rm -rf $refFile");  

why you delete the file ?

   exec( "echo $numr > $refFile");  

just go back in the file and rewrite the value

[Anon]

   $fpr     = fopen($refFile,rw);  

you are using $fpr on this line and $fp in line below !!!!
also you are not checking for error codes
if (!$fpr) {
echo 'error!'
exit;
}

   $numr    = fgets($fp,5);  

you are using different variables

   $numr    = +1;  

$numr++;

   exec( "rm -rf $refFile");  

why you delete the file ?

   exec( "echo $numr > $refFile");  

just go back in the file and rewrite the value

[Anon]

Uhhh, exactly how many times do you want to open the file, close the file, and fork another process just to update this counter? Try this for lower overhead (caution-- not tested!):

function counthits($file)
{
if (! ($fd = fopen($file,"a+")))
{
$ctr = 0;
}
else
{
fseek( $fd, 0 ); // back to beginning of file for read
if ($ctr = fgets($fd, 32))
{
$ctr++;
}
else
{
$ctr = 0;
}
fseek( $fd, 0 ); // back to beginning again for write
fputs( $fd, "$ctr\n" );
fclose($fd);
}
return $ctr;

Note that append-update mode is the only one that gives you everything you need in a single call to fopen():

* creates the file if it doesn't already exist
* retains the existing contents if it does
* allows both reading and writing

if (! $fd)
// append-update mode is the only correct one:
// creates the file if it does

[Anon]

Oops. I omitted the closing brace, plus left some extra stuff at the end.<br><br>Sorry for the &nbsp;&nbsp;sloppy&nbsp;&nbsp; editing.