Another form problem with combo box

[Anon]

I've tried to create the form that is in my other post by using tables to align the field boxes correctly. But the combo box doesn't work when its put inside of <TD></TD>. What am I doing wrong? Here's the code for this form: (of course the combo box probably won't update correctly since its not working correctly in my other post)

include ($DOCUMENT_ROOT.'/include/functions.php');

$hostname="localhost";
$dbusername="webuser";
$databasename="ditdb";

$db = mysql_connect($hostname, $dbusername);
$result=mysql_query("SELECT * FROM position ORDER BY position", $db);

GenerateHTMLHeader('Add D.I.T. Employee');

if ($submit) {
Add_Employee($first,$last,$extension,$pager,$cellphone,$homephone,$position_id);
if ($feedback) {
echo '<FONT COLOR="RED"><H2>'.$feedback.'</H2></FONT>';
}
} else {
echo "<FORM ACTION='$PHP_SELF' METHOD='POST'>
<TABLE BORDER=0 CELLSPACING=1 CELLPADDING=1 WIDTH='60%'>
<TR>
<TD WIDTH='25%'>First Name:</TD>
<TD WIDTH='75%'><INPUT TYPE='TEXT' NAME='first' VALUE='$first' SIZE='20' MAXLENGTH='20'></TD></TR>
<TR>
<TD>Last Name:</TD>
<TD><INPUT TYPE='TEXT' NAME='last' VALUE='$last' SIZE='20' MAXLENGTH='20'></TD></TR>
<TR>
<TD>Extension:</TD>
<TD><INPUT TYPE='TEXT' NAME='extension' VALUE='$extension' SIZE='10' MAXLENGTH='10'></TD></TR>
<TR>
<TD>Pager:</TD>
<TD><INPUT TYPE='TEXT' NAME='pager' VALUE='$pager' SIZE='8' MAXLENGTH='8'></TD></TR>
<TR>
<TD>Cell Phone:</TD>
<TD><INPUT TYPE='TEXT' NAME='cellphone' VALUE='$cellphone' SIZE='8' MAXLENGTH='8'></TD></TR>
<TR>
<TD>Home Phone:</TD>
<TD><INPUT TYPE='TEXT' NAME='homephone' VALUE='$homephone' SIZE='14' MAXLENGTH='14'></TD></TR>
<TR>
<TD>Position:</TD>
<TD><SELECT NAME=$position_id>";
while($myrow=mysql_fetch_array($result)) {
$position_id = $myrow["position_id"];
$position = $myrow["position"];
echo "<option value=$position_id>$position\n";
}
echo "</SELECT></TD></TR></TABLE><P>";
echo "<INPUT TYPE='SUBMIT' NAME='submit' VALUE='Submit Employee Information'>";
echo "</FORM>\n";
}

GenerateFooter();

?>

[Anon]

I'm not sure, but this looks wrong:

<SELECT NAME=$position_id>";
while($myrow=mysql_fetch_array($result)) {
$position_id = $myrow["position_id"];

I'm pretty sure you want the select to be:

<SELECT NAME=position_id>";

i.e. without the $

[Anon]

Thanks. That solved the problem of not adding the data to the database. But I still can't get the combo box to work within a table. All I get is a blank combo box.

[Anon]

I am almost sure you need an </option> tag on the line below, PLUS try single quotes for the var:

echo "<option value=$position_id>$position\n";

Like this:

echo "<option value='$position_id'>$position</option>\n";

And possibly your </select> may need to be inside the braces, too, not sure about that.