Need a fresh pair of eyes for script assistance

Anon

I'm new to PHP and am trying to have a form that a user can add entries into a MySQL database. Unfortunately, when I submit data, it just appears on the top of the add.php3 page and isn't making it into the database.

Here's what I'm using for a script:

<?
if ($submit) {
$db = mysql_connect("localhost", "msdsdb", "vip5330")or DIE("Connection
attempt failed");
mysql_select_db("msds", $db) or DIE("Database selection failed");
$query = "INSERT INTO msds VALUES ('$product_name', '$manufacturer',
'$supplier', '$common_name', '$dolu', '$notes', '$linked_name')";
echo "product_name: $product_name<BR>\n";
echo "manufacturer: $manufacturer<BR>\n";
echo "common_name: $common_name<BR>\n";
echo "dolu: $dolu<BR>\n";
echo "notes: $notes<BR>\n";
echo "temp file: $linked<BR>\n";
echo "file name: $linked_name<BR>\n";
echo "file size: $linked_size<BR>\n";
echo "file type: $linked_type<BR>\n";
echo "<BR>\n";
echo "<a href=msds/$linked_name><BR>\n";
$result=mysql_query($query, $db);

}

And here is the form script:

<form enctype="multipart/form-data" method="post" action="<?echo
$PHP_SELF;?>">
<P>Product Name: <BR><input type=text name='product_name' size=65><HR></P>
<P>Manufacturer: <BR><input type=text name='manufacturer' size=65><HR></P>
<P>Supplier: <BR><input type=text name='supplier' size=65><HR></P>
<P>Common Name: <BR><input type=text name='common_name' size=65><HR></P>
<P>Date of Last Update/Modification: <BR><input type=text name='dolu'
size=65><HR></P>
<P>Notes: <BR><textarea name="notes" name='notes' rows=3
cols=65></textarea><HR></P>
<P>Linked Document:<BR><input type="file" name='linked'
size=100><HR></P><BR>
<input type="submit" name="submit" value="Upload">
</form>

The URL is http://www.vipstructures.com/msds/add.php3

Any assistance or suggestions would be appreciated.

Thanks!

Michelle Tarby

Anon

You have to use:
$query = "INSERT INTO msds (fieldname1, fieldname2, fieldname3, fieldname4, fieldname5, fieldname6, fieldname7) VALUES ('$product_name', '$manufacturer',
'$supplier', '$common_name', '$dolu', '$notes', '$linked_name')";

fieldname1 - fieldname7 are the names of the fields of the database.

SaS.

Anon

i am assuming you are using mysql. the manual says this:

If you specify no column list for INSERT ... VALUES or INSERT ... SELECT, values for all columns must be provided in the VALUES() list or by the SELECT. If you don't know the order of the columns in the table, use DESCRIBE tbl_name to find out.

so the the column list is not necessary if you are providing a value for each column. i say this to correct SaS's post...
i am not sure why that isnt working for you however. here are some things to try:
- move $result to under $query to keep all database code together.
- try an 'echo $query' to see what your sql is looking like after variables are interpolated

good luck!
-paul

Anon

I am a total PHP newbie too, but here's one thing I noticed just from glancing at your code:

//comment your code every step of the way

//it helps you understand what's happening

//and it lets people who are looking at it understand too

//and I've found it very helpful in debugging

Anon

If I could trouble everyone again - I've been trying to use everyone's suggestions but am still having a problem.

Here is what I'm now using:

}

<form enctype="multipart/form-data" method="post" action="<?echo $PHP_SELF;?>">
<P>Product Name: <BR><input type=text name='product_name' size=65><HR></P>
<P>Manufacturer: <BR><input type=text name='manufacturer' size=65><HR></P>
<P>Supplier: <BR><input type=text name='supplier' size=65><HR></P>
<P>Common Name: <BR><input type=text name='common_name' size=65><HR></P>
<P>Date of Last Update/Modification: <BR><input type=text name='dolu' size=65><HR></P>
<P>Notes: <BR><textarea name="notes" name='notes' rows=3 cols=65></textarea><HR></P>
<P>Linked Document:<BR><input type="file" name='linked' size=100><HR></P><BR>
<input type="submit" name="submit" value="Upload">
</form>

Now its telling me that the add was successful, but my data still isn't making it into the MySQL database.

Any more suggestions?

Anon

Are you entering data into all fields of the msds table? If you have any NULL fields on your form, and are trying to write to a field that does not accept NULL's maybe that's the problem.

Just a thought.

Anon

make sure you have insert privelages on that table. thats all i can think of....