INSERT using PHP4

[Anon]

Hello,
I am having some problems INSERTING records into MySQL with PHP4. I have used this code with PHP3 just fine. Here it is:

            $sql  = "INSERT INTO server (";
            $sql .= "'$IP1', ";
            $sql .= "'$IP2', ";
            $sql .= "'$IP3', ";
            $sql .= "'$IP4')";
  $sql .= " VALUES";
            $sql .= "(";
            $sql .= "IP1, ";
            $sql .= "IP2, ";
            $sql .= "IP3, ";
            $sql .= "IP4);";

  mysql_connect($db_server, $db_user, $db_password);

mysql_db_query("server",$sql);

Is this right? If not, what is a more effiecient way of doing this?

[Anon]

Hi Bill!

For readability purposes, just use one assignment statement for a single sql statement.

For example:

$sql = "insert into tablename (fld1,fld2) values ('val1','val2')";

Cheers!

• Chris =)

[Anon]

Just make all of that in to a nice little one liner, like the other guy said. This would work to:

$sql = "INSERT INTO server ('$IP1','$IP2','$IP3','$IP4',
'$IP5')

Just break the line up, and then tabe it in so you know it's the same sql statement. Makes it much nicer.

[Anon]

Ok, got that part, but there is something wrong with the actual query part:

mysql_connect($db_server, $db_user, $db_password);
mysql_db_query("server",$sql);

Does this look right?

[Anon]

I use mysql_query() instead of mysql_db_query(). I believe they both have the same function.

Try this,

$db = mysql_connect("hostname","username","password");

if (!$db):
echo "Database Connection Error";
else:
$sql = "sql statement here"

$result = mysql_query($sql);
endif;