rand() with arrays help request

Anon

greetings all,

I'm gathering image names from a directory and am having a problem :

Code :

<?
$dir = "/image/dir";

$file_array = Get_Image_list($dir);

$max = count($field_array)-1;
srand((double)microtime()*1000000);
$index = rand(0,$max); // line 24
$file = $file_array[$index];

echo "$file";

Error :

Warning: rand(): Invalid range: 0..-1 in /home/my/dir/index.php on line 24

In Closing :

It does echo one graphic and it's always the oldest dated one and also gives the above error. I've read the rand() manual and various other tidbits of information and cannot figure why $max isn't giving a value, is this the problem?

Frustrated , hopeful and learning,

Philip

Anon

Naming is the problem. I ran this under PHP 3+ so I had to change the way it added the results to the array in the function call, but it works.

<?
$dir = "/image/dir";

function Get_Image_list($dir) {
if(!$dir) {
$dir = ".";
}

$file_array = array();
$file = array();
$dir_handle = opendir($dir);
$a = 0;//for adding the result to the array in PHP 3
while($file = readdir($dir_handle)) {
if((preg_match('/jpg/',$file)) || (preg_match('/png/',$file)) || (preg_match('/gif/',$file)) || (preg_match('/jpeg/',$file))) {
//for adding the result to the array in PHP 3, which doesn't have push
$file_array[$a] = $file;
$a++;
}
}

return $file_array;
}

$files = Get_Image_list($dir);

$max = count($files)-1;
srand((double)microtime()*1000000);
$index = rand(0,$max); // line 24
$file1 = $files[$index];

echo("$file1");

Seems that there was a conflict when you were reusing the names of variables within and outside the function. After changing the names to different across the board, I was able to make it function without a problem, that is if your intent was to pull a single file name randomly from the directory.

Hope it works for you.

Jim

Anon

Oops, remove the line in the function that reads:

$file = array();

I put it there for debugging and forgot to remove it. Sorry.

Jim

Anon

ooh yeah, works! thanks a lot jim, very very much appreciated. and now it's even php3 compatable! 😉

warm regards,

philip

Anon

I was trying to do the same basic thing, and out of furstration found this thread. I'm trying to do the same thing in php4, and I'v written it about five diffrent ways; I still get the rand() error.
It workes the first few times after you start httpd, but afterwords, it starts working, fewer and fewer times.

Anon

I am having the SAME problem, over and over again. I have upgraded the script, yet I still get it to give me errors. After the errors it worked once twice, then it just doesnt load the image! http://www.ionimagery.com . Thank you for your time and trouble.