Code Problem with vBulletin

Anon

Hello everyone,

I'm having problems at adding some features for vBulletin Lite. I want to make possible that it checks whether the entered p/w is correct or not. Here's the code:

$userdata=mysql_query("SELECT user,pass FROM members WHERE user=$username");
$dbusername=$userdata[user];
$dbpassword=$userdata[pass];

if ($dbusername==$username and $dbpassword==$password)
{
do something
}

Apparently this code doesn't even load the items from the DB table! I made some tests and never ever the pass nor user was displayed.

I looked at some other queries which vB uses; they look like this:

$foruminfo=$DB_site->query_first("SELECT active,allowposting,title FROM forum WHERE forumid=$forumid");

But this always return the vB error "Slight problems...Please contact the technical admin."

BTW it's in the newthread.php3 under action=="postthread"

Please help....

Anon

Hi!!
Wait a second!! Your mistake is this: mysql_query() return a query identifier. What you need to do next, is this:

$result=mysql_query("SELECT user,pass FROM members WHERE user=$username");
$userdata=mysql_fetch_array($result);
$dbusername=$userdata[user];
$dbpassword=$userdata[pass];

if ($dbusername==$username and $dbpassword==$password)
{
do something
}

Now it'll work. But I was looking your code and I think that, the next code, it's a better solution:

$result=mysql_query("SELECT user,pass FROM members WHERE user=$username AND pass=$password");
if(mysql_affetced_rows() != 0) {
// OK, user identified
} else {
// 0 matches... user/pass worng!!!
}

But this is just a simple idea... see ya!!

inK