Simple function, need help..

[Anon]

Hi there, i have a problem.. i don't really know how to code my own functions yet..

this function is not working correctly:

<?

function mysql_connection($DB_Host, $DB_User, $DB_Pass, $DB_Name, $result, $num_rows)
{
$DB_Host = "localhost";
$DB_User = "root";
$DB_Pass = "crystal";
$DB_Name = "kontaktannonser";

mysql_pconnect($DB_Host, $DB_User, $DB_Pass) or die ("Tyvärr så går det inte att komma åt databasen.");
mysql_select_db($DB_Name) or die ("Tyvärr, databasen är för tillfället inte tillgänglig.");

$result = mysql_query("SELECT * FROM test");
$num_rows = mysql_num_rows($result);

}

mysql_connection($DB_Host, $DB_User, $DB_Pass, $DB_Name, $result, $num_rows);
echo ($num_rows);

?>

But this works:

<?

function mysql_connection($DB_Host, $DB_User, $DB_Pass, $DB_Name)
{
$DB_Host = "localhost";
$DB_User = "root";
$DB_Pass = "crystal";
$DB_Name = "kontaktannonser";

mysql_pconnect($DB_Host, $DB_User, $DB_Pass) or die ("Tyvärr så går det inte att komma åt databasen.");
mysql_select_db($DB_Name) or die ("Tyvärr, databasen är för tillfället inte tillgänglig.");

}

mysql_connection($DB_Host, $DB_User, $DB_Pass, $DB_Name);
$result = mysql_query("SELECT * FROM test");
$num_rows = mysql_num_rows($result);

echo ($num_rows);

?>

does anybody know what i'm doing wrong in the function?

/Stefan

[Anon]

You just aren't very familiar with variable scope. In a PHP function, all variables created in a function are lost when the function exits. I.e. they do not exist outside the function. Further, PHP will not automatically import variables from outside without the global keyword to tell it to import the variable..

Lastly, the final assignment made in a function is returned to the calling program. It's considered good form to use a return keyword at the end of a function to return a value.

[Anon]

Furthermore, your use of parameters doesn't make any sense.
Params are used to send values to the function, so if you're
not going to be passing information from the higher level, don't
use parameters at all.

More likely, you should be using parameters to pass in those
values, rather than hard-coding them inside the function.