Stumped on a Query??

Anon

OK this has me stumped, and frustrated! I'm sending different queries to the same table within the same script file but getting an error with the second query?? Here's the code:
<PRE>

mysql_pconnect("$host", "$user", "$pass")
or die ("Cannot connect to database.");
mysql_select_db("$host")
or die("Cannot select database.");
$result = mysql_query("$selStmt")
or die("Error in query.");
$row = mysql_fetch_object($result)

or die("Internal error, try again."); //ok to here!

-
- //code here is mostly for counters and compares.

- //and write data to a file. Then....

mysql_db_query("$host", "UPDATE $tableName set ACTIVE='0', PACKAGE='$num' WHERE ROWID='$rowid' ")

or die("Cannot update data."); //this is where it falls over!??

//more code that never gets executed!
-
-
?>

Anything obvious?? Sure will appreciate any help...this one gots me!

Thanks,
Marcel.

Anon

First, what does the error message say? too much changes between your first and 2nd query functions. I'd check to see what the $host, $tableName, $num, & $rowid variables actually contain.

Anon

As for me, you should rewrite your SQL statement:

mysql_db_query("$host", "UPDATE ".$tableName." set ACTIVE='0', PACKAGE=".$num." WHERE ROWID=".$rowid)

Note that PHP variables should be included by ".$variable." marks into your script. That's the problem (may be, the part of problem, but what I can see). Also, if ACTIVE is numeric field, you should wrire like this: ACTIVE=0 - i.e. without quotation marks.

Anon

Actually you don't need to take the variables outside of the quotes. PHP figures it out.

echo "My name is $name";
echo "My name is " . $name;

Those lines both do the same.

Now, if you want an actual dollar sign, then you have to escape it.

echo "I make $dollars";//uses variable
echo "I make \$dollars";//prints out dollar sign, no variable.

Anon

John Holmes wrote:

echo "My name is $name";
echo "My name is " . $name;

Those lines both do the same.

yes, however the second line is "cleaner" code. Always something a good code poet should aspire to.

Anon

I disagree. I'd have to say the first example has "cleaner" code. Concating the vars with the string makes a mess with more than a couple of variables.

Take a look at this:

1) "SELECT $col1, $col2, $col3 FROM $table WHERE $test1 LIKE $test2"

2) "SELECT " . $col1 . ", " . $col2 . ", " . $col3 . " FROM " . $table . " WHERE " . $test1 . " LIKE " . $test2"

Two problems with the 2nd example. On the 2nd example can you see what spaces are for the SQL command and what spaces are to make it look pretty? It all runs together. Other issue is the quotation marks. I had to read the query a couple of times to be sure the syntax was correct.

Anon

Hi Brandon,

Yeah I did check their content. All hold the expected values. The error message is the one I included as my or die("..."); Also the column for ACTIVE is a varchar as it holds both integers and chars at different states which I use to test the account information. Any other ideas?

Marcel.

Anon

Well Annchen,

don't want to get into a style debate...but I prefer my way. Or the first if anyones keeping track. Also the column is not an int and therefor needs the '0' as indicated. Any other ideas?

Marcel.

Anon

Not really the question solution but a good point there JH...btw nice name!

Marcel.

Anon

I disagree...🙂

Marcel.

Anon

I agree...😉)

Marcel.

Anon

what does mysql client or mysql_error() say? using the die() function doesn't tell us much and there is only so much we can guess at with the snippet of code.

Anon

mysql_db_query("$host", "UPDATE $tableName set ACTIVE='0', PACKAGE='$num' WHERE ROWID='$rowid' ")

Are all of these table columns varchar or string?

The way you have it written I hope so. When you enclose $rowid in single quotes it means a string variable.

If you try and enter a string into a numeric field, I am pretty sure MySQL will vomit!

Good Luck

Anon

Well all involved, I got it! Yes all were varchar by the way and all info was present and was fine. Problem was that for test purposes I created a dummy table and inadvertently left out a column....whoooooppppsssss. Man do I feel like an idiot!

I want to thank you all for your help and advice. I learned more than I bargained for. Sorry if I wasted your time, I'll certainly be more careful and 'see' the obvious next time! Have a good one.

Cheers,
Marcel.