WHERE statments

Anon

I just started learning PHP 3 days ago.
so this maybe an easy question to awsner..

I am writing a script to edit a database.

$w_sqlstr = "UPDATE members SET " . "timezone = " . "'" . $a_members_timezone . "'" . ", " . "position = " . "'" . $a_members_position . "'" . ", " . "ICQ = " . $a_members_ICQ . ", " . "email = " . "'" . $a_members_email . "'" . ", " . "name = " . "'" . $a_members_name . "'" . ", " . "zcords = " . $a_members_zcords . ", " . "ycords = " . $a_members_ycords . ", " . "xcords = " . $a_members_xcords .", " . "WHERE (members.xcords=$xc AND members.ycords=$yc AND members.zcords=$zc)";

// Whenever I run it gets errors from the
// WHERE part ont he SQL statment that I load
// to a varible here.

wed_db_process("server", "user", "pass", $w_sqlstr);

Thanks for any help.

Paul

Anon

You could try it something like this...

Which should work fine in mysql.

$w_sqlstr = "UPDATE members SET timezone =$a_members_timezone, position =$a_members_position, ICQ =$a_members_ICQ, email =$a_members_email, name = $a_members_name, zcords =$a_members_zcords, ycords =$a_members_ycords, xcords = $a_members_xcords WHERE xcords=$xc AND ycords=$yc AND zcords=$zc)";

A couple of things I do when I'm having trouble with mysql queries but which should work for other databases are:

Echo the $w_sqlstr to the screen so that you can see what's actually being thrown at the database.
If everything looks Ok, try submitting the query shown from step 1 above directly to the database from a command line, the error messages you get back can be very revealing (you will need to substitute the variables for likely ones yourself).

Hope this helps

Paul

Anon

You can figure this one out, just add this:

print "<pre>";
print $w_sqlstr;
print "</pre>";

to your code. Now you can either look at it for obvious syntactical errors, or crank up an interactive sql monitor and cut and paste it into that and see what error you get.

And get rid of all those "." operators. There's no real need for them unless you need to use array values, but for ' and , you don't need them.