Piece of code --> is good?

[Anon]

Is there an easy or more "professional" solution to reach the same result ?

$wherereg="";
$wregista=explode(" ",$regista);
$j=0;
if (isset($wregista[$j+1])) {
$cognome=$wregista[0];
$nome=$wregista[1];	
$i = 1;
while ($i <= 2) {
$wherereg=$wherereg."registac LIKE '%".$cognome."%'";
$wherereg2=$wherereg." AND registan LIKE '%".$nome."%'";
	if ($i+1==2) {
	$wherereg=$wherereg2." OR ";
	$nome=$wregista[0];
	$cognome=$wregista[1];
	} else { 
	$wherereg="AND ".$wherereg; 
	}
$i=$i+1;
}
} elseif (isset($wregista[$j])) {
$wherereg="AND registac LIKE '%".$wregista[0]."%' OR registan LIKE '%".$wregista[0]."%'";

} else {
$wherereg="";
}

It takes me about 2 hours to reach this (I think) poor result ...yes it works... but I think it could be better... could you eventually explain me where I could optimize ?

Now I have to solve the same trouble, but this time the Database fields to be compare are not only 2 but 6 !! ...I'm a bit worried about...

Thank you for your answers

[Anon]

I started to look at it but decided it was just too ugly. My biggest hint that this was a very poor design is in your column names: registac and registan

You need to use column names that make sense by looking at them, not by looking at them then consulting an oracle.

Per many standards, variable names (and this goes very well for column names) should be unique within the first six characters. In the above example we have to dig 8 chars deep to find a difference.

$cognome and $nome make no sense at all and wregista and regista having a different first letter but one exploding into another is crap. Write your code in your native language and use caps to seperate words.

WRegIsTa, were the variable to make sense in the first place, would help. $WindowsRegistryIsTotalAsswipe is a much better variable name.

Also, never modify your iterator in an evaluation...do it on it's own line to make it more clear when the iterator is moved to the next value.