FIX MY @%#^$ FUNCTION!

Anon

Any ideas why this function always returns 0?

$urls = array("rareearthdesign.com","urgent-lemon.com");

function validateReferer($urls){

	foreach($urls as $url){
	if(strstr($HTTP_REFERER,$url)){
		return(1);
		} else {
		return(0);
		}
	}
}

I'm submitting form data from www.urgent-lemon.com, the function is supposed to disallow any input from a domain other than the ones in the array, but instead denies ALL input. HELP!

Thanks in advance!

Anon

freakin declare $HTTP_REFERER as global first dude.

Anon

<?
$urls = array("rareearthdesign.com","urgent-lemon.com", "uniquefocus.com");

function validateReferer($urls){
global $HTTP_REFERER;
while(list($key,$url) = each($urls)) {
if(strstr($HTTP_REFERER, $url)){
$found = 1;
}
}
if($found) {
return TRUE;
}
else {
return FALSE;
}
}
?>

Anon

Pet peev:

if($found) {
return TRUE;
}
else {
return FALSE;
}

should always be written as
return ($found);

Thanks

Anon

Its your pet peev not mine

Anon

You keep doing sloppy code while Tom does it right, then.... 🙂

---John Holmes...

Anon

I guess that would be a personal preference.

Anon

ok...

Anon

Hey John is that your new general reply, when you don't feel like arguing anymore? Come on its all in fun!

Anon

Maybe he thinks saying "ok" is better than saying "If you prefer do it the dumb way go ahead!" :-) We have a fairly low occurance of rwars around here (other than when somebody stumbles in and ask an IIS+ASP question!) and as far as I'm concerned we should keep it that way...

Anon

Cool with me.... I learned that I was wrong in the post from Tom, I just didn't like the way he responded that is why I responded as I did. Maybe if people handled themseleves a little more civil when correctin gothers this wouldn't happen

Anon

Yeah....that's my default, see...

function respond($response = "ok...")
{
echo $response;
}

It's also my default in the database...

CREATE TABLE respond (
id INT NOT NULL AUTO_INCREMENT,
response VARCHAR(100) DEFAULT 'ok...',
PRIMARY KEY(id)
);

You got a problem with that!?!? 🙂

---John Holmes...

Anon

You've got to credit me if you're going to use my code....ok?

---John Holmes...