php mailer 2

[Anon]

Ok i rewrote the php mail but now i get another error ...
here's the code :

<?
$send=trim($send);
$mailto=trim($mailto);
$sub=trim($sub);
$body=trim($body);
$from=trim($from);
$password=trim($password);

if($password != '' && $password = 'passwd') {
if($mailto != '' && $sub != '' && $body != '' && $from != '' && $send != '') {
mailer($mailto,$sub,$body,$from,$send);
}

else {
formmail();
}
}

else {
passform();
}

function mailer($mailto,$sub,$body,$from,$send) {
$x = 0;
while($x < $send) {
$x = $x + 1;
mail($mailto,$sub,$body,"from: $from");
echo "
<br>Message sent $send times :
<br>To : $mailto
<br>From : $from
<br>Number of times : $send
<br>Subject : $sub
<br>Message Body : $body
";
}

function formmail() {
echo '
<form action="mailer.php" method="post">
Mail To: <input type="text" name="mailto"><br>
From: <input type="text" name="from"><br>
Number to send: <input type="text" name="send" size="20" value="1"><br>
Subject: <input type="text" name="sub"><br>
Message: <input type="text" name="body" size="23">
<input type="submit">
</form>
';
}

function passform() {
echo '
<form action=mailer.php method="post">
Enter Password : <input type="password" name="password">
';
}
?>

or you can go to www.mycgiserver.com/~zruya/mailer.phps

here's the error :

Parse error: parse error in /wwwroot/mycgiserver.com/members/cRyNOvBTp6Mp2GpPUErAZruMcANwrwQ9/mailer.php on line 59

please note : adding a ';' in the end a line before the ?> doesn't help 🙁

please tell me whats the problem ?!? what am i doing wrong ?!?

thanks in advance .

• matan zruya

[Anon]

Matan,

You need to escape your " characters in an echo statement.

eg/

function passform() {
echo '
<form action=mailer.php method=\"post\">
Enter Password : <input type=\"password\" name=\"password\">
';
}

Hope this helps

Mike
www.digitalegg.net

[Anon]

and why only in that passform function and not any of the others ?

[Anon]

and btw ... no change 🙁 thanks anyway ... just notice that the error message is on line 59, the ?> line .

• matan zruya

[Anon]

Matan,

Here is where your problem is:

else {
formmail();
}
}

Notice the extra }, usually if you get an parse error on the last line it will be a problem with parantheses not matching.

Hope this helps

Mike
www.digitalegg.net

[Anon]

the extra }
closes the if($password != '' && $password = 'passwd') {
if i'd remove it more errors would popup .

i'll explain what it does ... if the user enters the password passwd then check if $mailto $... $... are not empty .. if they are not empty mail the e-mail else redisplay the e-mail forms . and now the last else reffers to if $password is empty redisplay the passwords form .

[Anon]

Matan,

Sorry, missed that, but the problem is still the same, check this function, you are not closing the function with a }, only the while statement:

function mailer($mailto,$sub,$body,$from,$send) {
$x = 0;
while($x < $send) {
$x = $x + 1;
mail($mailto,$sub,$body,"from: $from");
echo "
<br>Message sent $send times :
<br>To : $mailto
<br>From : $from
<br>Number of times : $send
<br>Subject : $sub
<br>Message Body : $body
";
}

Mike
www.digitalegg.net

[Anon]

ok ... the script would now run fine 🙂 but ( i hate that 'but' ) when i'm presented with the password form i enter passwd and press enter ... it sends me to the mail forms i fill up everything ... click submit and i'm presented with the password form again, i don't understand ... why is it jumping to the to the passform() when the mailer function is not yet completed and has a results page to display ?

and one more thing i just found out that the password form accepts every password 🙁

thanks in advance .

• matan zruya

[Anon]

i think i'v found the problem ... when i click submit in the mailer forms for some reason it resets the $password and bringing me back to the start of the loop ... if i try using : mailer.php?password=passwd&mailto=[e-mail]&sub=blah&body=blah&send=1&from=[e-mail]

it will send the e-mail, and everything will work fine ....

• matan zruya