Error correction needed! Help me!

Anon

I have an HTML-form where the user can choose if he wants to search for a person by AZONOSITO or NAME. This is stored in $SZEMPONT. What he actually enters in an input field is stored as $MIT. Then I have this PHP-page which is supposed to examine whether there is such a person or not. But so far, it doesn't find any of the entered people. Where is the mistake?

Help me, please!

Thanks, Akos

<head><title>Modositas</title></head>
<body>
<form method="post" action="dolg_mod3.php">
<table>
<?
$dbhost = HOST ;
$dbuser = USER ;
$dbpass = PASSWORD ;
$db = mysql_connect($dbhost,$dbuser,$dbpass) or die("Hiba a kapcsolódáskor!") ;
$dbname = "gepek" ;
mysql_select_db($dbname,$db) ;
if ($szempont == "azonosito")
{
$azon_query = "select * from tanszeki_dolgozok where azonosito = '$mit'" ;
$azon_result = mysql($azon_query,$db) ;

$azon_num = mysql_num_rows($azon_result) ;
if ($azon_num == 0)
{
echo "<h3>Nincs ilyen azonositoju dolgozo! Probalja ujra!</h3>" ;
exit ;
}

else
{
$azon_adat = mysql_fetch_array($azon_result) ; ?>
<tr><td><input type="text" name="nev" value="<? $azon_adat["nev"] ?>"></td></tr>
<tr><td><input type="text" name="email_cim" value="<? $azon_adat["email_cim"] ?>"></td></tr>
<?

}

}

else
if ($szempont == "nev")
{ echo "<h3>Nincs ilyen nevu tanszeki dolgozo! Probalja ujra!</h3>" ;
exit ;
}
else
{

$nev_adat = mysql_fetch_array($nev_result) ; ?>
<tr><td><input type="text" name="nev" value="<? $nev_adat["nev"] ?>"></td></tr>
<tr><td><input type="text" name="email_cim" value="<? $nev_adat["email_cim"] ?>"></td></tr>
<?
}
}

?>
</table>
<input type="submit" name="submit" value="Modosit">
</form>
<br>

<a href="dolg_mod.html">Vissza</a>" ;
</body>

$nev_query = "select * from tanszeki_dolgozok where nev = '$mit'" ;
$nev_result = mysql($nev_query,$db) ;

$nev_num = mysql_num_rows($nev_result) ;
if($nev_num == 0)
{

Anon

Not sure what's wrong but I do see some things that might need some fixing:

You use <? $fieldname ?> as value for an input field (value="<? $field ?>") this will not actually echo the value to the forum field.

<? echo $fieldname ?> (php3)
or:
<?= $fieldname ?> (php4)

Will fix that problem.

You if statement:
if ($szempont == "azonosito")

Are you sure $szempont is equal to "azonosito" ? Because if not, the Query will not be excuted and you offer no alternative.

I would change this to:
if ( $szempont == "azonosito" ) {
[ do query ]
} else {
echo "<p>There was a problem<br />szempont = $szempont</p>\n";
}

So, if the if fails, at least it shows you what $szempont did contain.

Anon

Thanks for the quick reply.

I'm absolutely sure that $szempont should be equal with either "AZONOSITO" or "NEV" because the user can choose between these two from a list panel. And I tested it with existing people with azonosito=0 or nev="David Akos", but still it doesn't find them. I'll try what you said, but whati s your opinion about this?

All the best, Akos

Anon

The browser displays the following error message:

Warning: Supplied argument is not a valid MySQL result resource in /home/davida/public_html/dolg_mod2.php on line 36

and then my error message: "Nincs ilyen nevu...."

line 36: $nev_num = mysql_num_rows($nev_result) ;

And it didn't display anything although I inserted your error message displaying line into the program.

Any ideas?

Thanks, Akos

Anon

Well...

Normally I would understand better if I could read the response you give to the user.

E.g.

echo "<p>No user found</p>";

Makes it clear to me, that if the code reaches this point the user is not found.

However,

Nincs ilyen nevu tanszeki dolgozo! Probalja ujra!

Ehhm... is this good or bad? ;-)

The statement belongs to $szempont == "nev", if $szempont equals "nev" would that be good? ;-)

And azonosito=0 ehhh?? azonosito??? ;-)

Anon

That either means you are using a wrong field name (typo?) or you don't supply your database.

To figure out, place this line directly after any SQL statement (like mysql_query)

echo "<p>Error:<br>" . mysql_error() . "</p>";

That will tell you what's wrong with your SQL statement.

Anon

Sorry Martin,

I'm from Hungary, and I just forgot about the fact that others might not understand our language.

"Nincs ilyen nevu felhasznalo" means that there is no such user (with this name).

"azonosito" menas identifier and is used as the primary key of that table. If it is "0" that means that the user left this field empty.

$szempont stores what the user wants to use to search for a person in the database (by name or by the identifier). So if $szempont equals with "nev" that means that the user makes the query using the name field.

:-))))))))))))) Sorry again for confusing you.

Martin wrote:

Well...

Normally I would understand better if I could read the response you give to the user.

E.g.

echo "<p>No user found</p>";

Makes it clear to me, that if the code reaches this point the user is not found.

However,

Nincs ilyen nevu tanszeki dolgozo! Probalja ujra!

Ehhm... is this good or bad? ;-)

The statement belongs to $szempont == "nev", if $szempont equals "nev" would that be good? ;-)

And azonosito=0 ehhh?? azonosito??? ;-)

Anon

One more question.

If I want to make a search query but I want the system to find the next best hit for me. Eg.:

I'm looking for "David Akos" in the database. I know that he is there so I just enter "Dav" and still the system should retern the expected result.

I think I should use LIKE but I don't know the syntax.
Can you help me?

Thanks, Akos

Anon

$sql = "SELECT * FROM table WHERE name LIKE '%$variable%'";

Anon

Akos David wrote:

Sorry Martin,

I'm from Hungary, and I just forgot about > the fact that others might not understand > our language.

On the other hand, if I write "begrijp je wat ik nu schrijf" alot of people would understand as I've seen alot of Dutch people wondering around PHPBuilder ... ;-)

But, tell me if the problem remains now that I know what it says ;-)

Anon

Thanks a lot, Martin!

The problem is solved, but another one has emerged. Here is my script which is supposed to do a multiple deletion with checkboxes. That is beautiful. But there is a field LEIRAS (stands for "description") which doesn't necessarily contains information as the user might leave this field empty. But when this script displays the table I want to replace all the empty LEIRAS fields with   in the table (it looks much better). I know that I can do this with creating an IF structure like this:

if (LEIRAS == "")
{
<td> <? echo   ; ?> </td>
}
else
{
displaying LEIRAS
}

But I can't find my way between the symbols %. I got this help earlier but it's still not clear what exactly I can do with this SPRINTF function. Could please help me and fix the code or tell me what the solution is?

Thanks,

the Hungarian

<?
$dbhost = HOST ;
$dbuser = USER ;
$dbpass = PASSWORD ;
$db = mysql_connect($dbhost,$dbuser,$dbpass) or die("Hiba a kapcsolódáskor!") ;
$dbname = "gepek" ;
mysql_select_db($dbname,$db) ;

if ($submit)
{
for($i = 0 ; $i<count($action_items) ; $i++)
{
$query = sprintf("delete from hiba where sorszam = '%s'",$action_items[$i]) ;
mysql_query($query,$db) ;
}
}
$result = mysql_query("select sorszam,bejelento_email_cime,date_format(rogzites_ideje,'%Y-%m-%d %T') as
date_time,leiras,leltari_szam,hibakod,javitva from hiba order by sorszam desc",$db) ;
?>

<head><title>Rogzitett hibak listaja</title>
</head>
<body>
<h1>Rogzitett hibak listaja</h1>
<h3>(Jelölje ki a torolni kivant rekordokat, majd kattintson a Torol
gombra!)</h3>
<table border="3" cellspacing="5" cellpadding="5">
<form action="<? print $PHP_SELF ; ?>" method="post">
<?
while ($row = mysql_fetch_array($result))
{
printf('<tr><td><input type="checkbox" name="action_items[]"
value="%s"></td><td>%s</td><td>%s</td><td>%s</td><td>%s</td><td>%s</td><td>%s</td><td>%s</td></tr>',$row["sorszam"],
$row["sorszam"],$row["bejelento_email_cime"],$row["date_time"],$row["leiras"],$row["leltari_szam"],$row["hibakod"],$row["javitva"]) ;
}
?>
<tr>
<td align="left"><input type="submit" name="submit" value="Torol"></td>
</tr>
</table>
</form>
<a href="admin_menu.html">Vissza</a>
</body>

Anon

I want to replace all the empty LEIRAS
fields with nbsp in the table (it looks
much better).

if (LEIRAS == "")
{
<td> <? echo   ; ?> </td>
}
else
{
displaying LEIRAS
}

The nbsp code get escaped by this forum, showing up as empty space (as it should in html ;-)) But I understand what you mean.

You should of course use:
if ( $leiras == "" )

So don't forget the $ before leiras!

Also, you echo something using php, so you should also put this between quotes, "code" e.g.:
<td><? echo "thenbspcode"; ?></td>

I use "thenbspcode" otherwise it get's escaped, but you know the code.

That's all I can see is wrong with it.