$i doesn't increase in while statement

Anon

When I submit a form I use the following code:

<?
if ($Submit)
{
reset ($HTTP_POST_VARS);
$i=1 ;
$var = \"\";
while (list ($key, $val) = each ($HTTP_POST_VARS)):
echo \"<br>\".$i;
$i++;
endwhile;
echo $var;
}
?>

It prints a list of number (1,2,3,4,5 ...)

But when I add a line to the code $i is not being increased by 1!!! Does anyone knows how this can happen and what to do about it? So it executes the if-statement and also increases $i?

The following code is the one which doesn\'t increases $i:

<?
if ($Submit)
{
reset ($HTTP_POST_VARS);
$i=1 ;
$var = \"\";
while (list ($key, $val) = each ($HTTP_POST_VARS)):
if ($i=1) { $var .= $val; } else { $var .= \";\" . $val; };

	echo \"<br>\".$i;
	$i++;
endwhile;
echo $var;

}
?>

Anon

Hi,

Back again I see ;-)

First:

if ( $i=1 )

That should be:

if ( $i == 1 )

(comparison)

You are actually assigning value 1 to $i on every iteration. So,

$i = 1;
[iteration]
$i is assigned 1 by the if statement
$i is incremented by one
[iteration]
$i is assigned 1 by the if statement
$i is incremented by one
[etc]

Get the idea?

Other than that, I see you continuously escape all the quotes (") is this something this forum does, or is it actual code?

$var = ""; // makes $var empty
$var = \"\"; // does ?!?! I dunno..

But I see what you are trying to do, if it's the first iteration, don't use ";" otherwise use it.

You know what I always do? (very quick and dirty I agree)

$var .= $val . ";";

And after the loop do:

$var .= ";";

This creates something like this:

value1;value2;value3;;

Then I do:

$var = ereg_replace(";;", "", $var);

I know it's perhaps not the most perfect way, but creating extra if statements is also not all that perfect.

Anon

May I be as unpolite as to suggest chapter 2 of the php manual, "Language Reference" especially "Control Structures".

And more specific (in the light of your problem):
http://www.php.net/manual/language.operators.assignment.php

http://www.php.net/manual/language.operators.comparison.php

I think that would benefit your PHP skills ;-)

Anon

If you're trying to create a semi-colon delimited string of your http post vars, why not just use

$string = implode(";",$HTTP_POST_VARS);

---John Holmes...

Anon

Yep you're totally right there!
Like I said, I was in a hurry and forgot ==, just like in Pascal back in the early days evryone forgot ;
I'm ashamed !
Haha, thanks for your advice!

Patrick

Anon

-sigh- why didn't I think of that ;-(

Anon

now you know....next time you can be the one to answer first.. 😉

---John Holmes...

Anon

Well Martin, your solution is better for me, because I can add an option so that the Submit button is not included in the string!
With John's sollution a string is created that ends with ;Submit which I don't want.
Your script is working perfectly!

I made this and now it is working OK!

<?
if ($Submit)
{
reset ($HTTP_POST_VARS);
$i = 1 ;
$var = "";
while (list ($key, $val) = each ($HTTP_POST_VARS)):
if ($val!="Submit")
{
if ($i==1) { $var .= $val; } else { $var .= ";".$val; };
}
$i++;
endwhile;
echo $var;
$fp=fopen("test.txt", "a+");
fwrite($fp, $var);
fclose($fp);
}
?>

Damned!!! \'s are added by this forum!