Bad Array?

Anon

Below is the code I am using for a small search engine. in "List.txt" there are 3 entries that should come up when searched for. Although, when actully searched, only the first two are printed, and the last is left off. Any ideas?

$foundone=0;
$title=range(1,100);
$link=range(1,100);
$text = file("list.txt");
sort($text);
$num_elements = count($text);

for ($i=0; $i<$num_elements; $i++)
{
if (eregi($keywords, $text[$i])) {
eregi("<topic>(.)</topic>", $text[$i], $title);
eregi("<exten>(.)</exten>", $text[$i], $link);
$link[$foundone] = strip_tags($link[$foundone]);
$title[$foundone] = strip_tags($title[$foundone]);
echo ($foundone."- <a href=\"$link[$foundone]\">$title[$foundone]</a><br>");
$foundone++;
}
}

Anon

could it be that your testing for less than i?

was:
for ($i=0; $i<$num_elements; $i++)

should be:
for ($i=0; $i<=$num_elements; $i++)

im a newbie, so i might be just rambling nonsense..

Anon

If I were you, I'd put some extra echos into the code, to trace whats going on. At least then you'd know whether its reaching / finding the third match.

Also - maybe this snippet is out of context, but I don't see why you need arrays to hold the matched items. By the look, you're putting them out as <a href ...> tags on the page. Simple variables would do instead of arrays.

Anon

No, you need to stop at one less than the number of elements, because arrays are indexed starting at zero.

So the elements of a 50 element array are numbered 0 to 49.

Anon

thanks guys, Both of your comments helped. => I guess I could just print it out to the screen... I did place some var's in there to help track, but I appears like its just not being placed into the array. when I do $link[$2] or whatever, it prints out "Array".

anyway, thanks again.

Derek
www.etecc.com

Anon

I took off the arrays, but for it just prints out "1" all the time. I was setting the var $title equal to eregi("<topic>(.*)</topic>", $text[$i]); Im pretty sure thats the way I should do it?

derek

Anon

Think I've got the answer to this now, which took a while because I don't use eregi much myself - the patterns can get complex. Hence my previous comment about arrays, which I now see that you must use.

So:

eregi("<topic>(.*)</topic>", $text[$i], $title);

This loads $title[0] with the string which matches the pattern, and it loads $title[1] with the string which matches the subpattern in () brackets. In your case, these will both be the same. So now, you just need something like this:

$alink = strip_tags($link[1]);
$atitle = strip_tags($title[1]);
echo ($foundone."- <a href=\"$alink\">$atitle</a><br>");

I think that by trying to use $foundone as an index to the arrays, you've overwritten the results of the eregi itself.

Hope this is it!

Anon

Yeaaa! Thanks Martin, you did it. You just have to love those logical errors. Now that you found it, I see that it did keep on over writing itself. ;~)

Thanks Again,

Derek