Newbie Form and password problem

Anon

I've been asked to create a web site by a friend and i'm kind of learning PHP4 on the fly. I've posted my code at:
www.ucalgary.ca/~myuen/index2.html

The problems i'm having are as follows:
1. My form inserts data into two areas, basic info (ie: name, address, etc.) goes into the clients table and their interests go into a interests table. Problem is, the interests data is not going into the interests table. The clients info works great.

I'm having problems with comparing passwords. It is not comparing the users password with their confirmation password.
lastly, i'm getting a parse error on line93 but I can't seem to find out what's wrong with it.

Thanks in advance,
Marco

Anon

Hi,
I have solutions to your three problems which may/may not work because I'm new to PHP too.

1) error inserting into interest table:
I don't think you can use a for loop inside the sql query. Try to reverse the process and use the sql query in the for loop instead.

2) Password problem. Instead of using PHP to verfiy the passwords to see if they match, why not use Javascript? you may use the following code to validate (using javascript). Note: Case sensitive comparision:

if(document.[form name].[password field name].value!=document.[form name].[confirm password field name].value){
alert("error message');
}

3) Most probably you are encountering a syntax error..To loop, is it FOR or FOREACH?
I have no problem using FOR and WHILE. And you didn't enclose with curly braces {} the statements in the FOR loop. Will this be causing the problem? PHP is very fussy when it comes to () and {}.

Regards,
Michael
19/12/2000 (dd/mm/yyyy)

Anon

1 ) I don't know 🙂
2 ) Try

if($givenpassword == $setpassword) {
print("Password Correct);
} else {
print("Password Incorrect");
die();
}

3 ) Look for a missing ";" see my script above as an example as to where ";"'s goes.

Anon

1) mysql is very basic sql, it most certainly does not understand foreach loops.

2) Bad idea becuase if users disable their javascript...
Instead use php to compare the passwords and re-print the form (filled-out) if something is wrong.

3) Use proper indentation, so you can see if there are enough closing brackets.

The IF statement above line 93 appears to have one opening bracket, and two closing brackets.
I'm too lazy to check if all your brackets match.

Anon

Some editors (e.g. editplus on Windows and emacs on Linux) have brace-matching functions. I'm too lazy to even check if my own brackets match, so I let my editor do the matching for me.

Vincent,
Is it common for people to disable javascript? My site won't work without it. I'm not going to rewrite the whole thing, but if it's an issue, I could at least check for it and let them know they'll need to turn it on to use the site.

Beth

Anon

Beth,

It happens more often than webdesigners think.
Especially with those agressive popup windows on some sites. You know the ones where you open one page and automatically it opens three other windows full of commercial sh*t. Those windows are not opened if you have javascript disabled.

Anon

I just try to avoid those sites.

Thanks for the info. I'll go ahead and add the code.

Beth

Anon

giggle but they are such fun :-)