RegExp Woes

Anon

Hello, I recently created a function that works okay, but has a bad, cheap, hack. Here's it is:

function specialCode ($parse, $linkHTML = $linkHTML, $postlinkHTML = $postlinkHTML)
{
$regexp = '([^[])';
$regexpPost = '([^<br>|-|/|| |😐;|.|,|[|)|(])';

for ($c = 0; $c < 5; $c++) {
	$parse = eregi_replace ("\[b\]$regexp\[/b\]", "<b>\\1</b>", $parse);
	$parse = eregi_replace ("\[i\]$regexp\[/i\]", "<i>\\1</i>", $parse);
	$parse = eregi_replace ("\[quote\]$regexp\[/quote\]", $quoteHTML, $parse);
	$parse = eregi_replace ("\[link\]($regexp)\[/link\]", $linkHTML, $parse);
	$parse = eregi_replace ("\[link=&quot;$regexp&quot;\]$regexp\[/link\]", $linkHTML, $parse);
	$parse = eregi_replace ("Post \#$regexpPost", $postlinkHTML, $parse);
}

return $parse;

}

In order to get 'global' searching I've used a for loop. This is a bad hack, I'm ashamed. Can someone please fix up my regular expressions. I don't want it to just replace all 's than all 's. I don't want users screwing up the page, if they know they can, they will.

Btw, I'm trying to do UBB style code. I'm not using mySql.

pnoeric

Rizzuh, I tried to figure out exactly what's going on here and my head starting hurting... but it's not your code, it's regular expressions, they always do this to me ;-) I can't help much with that but I noticed you don't pass $quoteHTML into the function, and in your function declaration, I don't think you need to set the variables equal to themselves; it has no effect.

Sorry I can't be of more help just yet. Are you trying to strip all "bad" HTML tags from the four strings $parse, $postHTML, $linkHTML and $postlinkHTML?

best,
Eric

Anon

Here's some updated code:

function specialCode ($parse, $postlinkHTML = 'Post <a href="#\1">#\1</a>')
/
Parses special code on The CS Crossfire. First argument is the variable to parse,
second is the optional new code linking to posts using the # sign. The second arg
is used for the preview and displaying user information, as it would point to an
area on the page that doesn't exist.
/
{
$regexp = '([^[])';
$regexpPost = '([^{<br>|-|/|| |😐;|.|,|[|)|(]})';

$quoteHTML = '<blockquote>\\1</blockquote>';
$linkHTML = '<a href="\\1" target="_blank">\\2</a>';

for ($c = 0; $c < 5; $c++) {
	$parse = eregi_replace ("\[b\]$regexp\[/b\]", "<b>\\1</b>", $parse);
	$parse = eregi_replace ("\[i\]$regexp\[/i\]", "<i>\\1</i>", $parse);
	$parse = eregi_replace ("\[quote\]$regexp\[/quote\]", $quoteHTML, $parse);
	$parse = eregi_replace ("\[link\]($regexp)\[/link\]", $linkHTML, $parse);
	$parse = eregi_replace ("\[link=&quot;$regexp&quot;\]$regexp\[/link\]", $linkHTML, $parse);
	$parse = eregi_replace ("Post \#$regexpPost", $postlinkHTML, $parse);
}

return $parse;

}

The function now works correctly.

What I'm trying to do is turn into <b>, etc. I'm trying to do a global search and replace type deal.

pnoeric

Ah, gotcha. Could you use htmlentities() and/or htmlspecialchars(); to make the job easier?

best,
Eric Mueller

Anon

That really wouldn't affect anything. Uh..