Delete Checkboxes Trouble

harris97

I've already read much about solving this problem, but no one works for me. I'd like to show all records and then beside each record has checkboxes in order to delete. Like this :
NO | Name |
1 | A |[v] // cheked delete
2 | B |[v] // uncheked do not delete

DeleteButton

Please help me to correct my source code:
<?php
///.....code for connect db here
$query = "select NO, NAME from table";
$result = @($query);
if (mysql_numrows($result) > 0) {
?>
<form method="post" action="<?php echo($PHP_SELF);?>" name="Delete">
<table width="61%" border="1">
<?php
$id=0;
while ($row = mysql_fetch_array($result)) :

$id++;
?>
<tr>
<td><%=$row[0]%></td>
<td><%=$row[1]%></td>
<td><input type="checkbox" name="id[]" value<%=$id%>>">
</td>
</tr>
<?php
endwhile;
?>
</table>
<br>
<input type="submit" name="Submit" value="Delete">
</form>

/// if delete button pressed
<?php
if ($Submit == "Delete") {
for ($i=0;$i < count($id); $i++)
{
$sql_id = $sql_id ."id=$id[$i]" . " OR ";
}
#Chop off the last OR statement on $sql_id
$sql_id = substr($sql_id, 0, -3);
$sql="DELETE FROM table WHERE $sql_id";
$result = @($sql);
}
?>

Showing records are successfull because html code showed like this :
<input type="checkbox" name="id[]" value="1">
<input type="checkbox" name="id[]" value="2">
....etc
So the problem is happened when delete button is clicked. Whats wrong with this query delete?

Thanks A lot for anybody for helping me

Anon

First of all, this:

Should look more like this:

i.e. you forgot the = after value

Next, you probably want to do the following, instead of:

for ($i=0;$i < count($id); $i++)
{
$sql_id = $sql_id ."id=$id[$i]" . " OR ";
}

Use:

foreach ($id AS $thisid) {
$sql_id.= "id= '$thisid' OR ";
}

Then continue with whatever else you were doing. This should do the trick much nicer. If your still having problems, get the SQL error message outputed by mysql (echo mysql_error()), plus the SQL that this is creating and that should help in aiding you.

Hope that helps!

Chris King