Do this &quot;neater&quot;?

Do this "neater"?

Can this be done in a more efficient way?

Function RemoveLastChar($str,$chr=",")

{
$str = trim($str);
if ( substr($str,(strlen($str)-1),1) == $chr )
{
$str = substr($str,0,(strlen($str)-1));
}
return $str;
}

What it does:
$string = "SELECT * FROM TB WHERE name = 'hello', full_name = 'cool', ";
$string = RemoveLastChar($string);
#returns:

SELECT * FROM TB WHERE name = 'hello', full_name = 'cool'";

You could do:

$string = substr(trim($string), 0, -1);

And get the same effect. It seems like you also want to make sure it is a specific character, so it would be easier to just keep what you have.. or

function removelastchar($string, $chr) {
if (substr(trim($string), 0, -1) == $chr)
$string = substr(trim($string), 0, -1);
return $string;
}

easy enough? Just a little more readable. Hope that helps ??

Chris King

Thank you, yes that last -1 was the trick!

You can read characters from a string just like you read elements from an array:

$a="hello";
echo $a[1];

would print "e";

so you could use
$str=trim($str); <<-- this should have been done before it went into the database

if ($str[strlen($str)-1]==$chr)
{
$str=substr($str,0,strlen($str)-1);
};

refined to the thread:

function rm_last_chr($s,$c=',')
{
if ( $a[(strlen($a)-1)]==$c )
{
$s = substr($s,0,-1);
}
return $s;
}

What you recommended Vincent, is that a new feature of PHP 4?

(I guess I'm a little bit spoiled with Pythons string manipulation.
if s[-1] == ",":
return s[:-1]
)

Vinny,

I'm on a company trip and I have to find this out before it kills me, I don't have access to my server.

$a="hello";
echo $a[1];

$a="hello world";
echo $a[?]; ---> echo $a[-5];

to print "helloworld";

In otherwords w/o the space.

and

$a="hello world it/'s me";

echo $a[1,12,1,12,4];

to print "eieio"; <grin>

To take out spaces in a string:
$string=preg_replace("/ /","",$string);

and

You'll have to write a new $a[] for each character you want to print;
echo $a[1].$a[54].$a[2];

Note the dot between the $a[]s, not a comma.

Very Very Cool!

Thanks....