Free counter doesn't add!

Anon

I got the below...

// Full sys path to count.txt
$counter_file = "http://www.site.com/count.txt";

// Puts the file lines into $counter_file_line array
$counter_file_line = file($counter_file);

// adds one to the number in the [0] array or the very first line
$counter_file_line[0]++;

// opends the file and then writes the new number and then closes it
$cf = fopen($counter_file, "w");
fputs($cf, "$counter_file_line[0]");

fclose($cf);

// prints out the full count
echo "$counter_file_line[0]";

checked it all out and made sure only needed to change the location, anyways, it doesn't work, just displays 1, how ever many time you refresh, (yes, I've tried getting others to visit as well).
The count.txt file is chmoded to 664 I think, its got group write permissions anyways and as it echos the "1" at the end, it seems to be partly working, just not counting!

Thanks for any help.

fabbe

<?php
//working example
$counterFile = "hits.txt";
if (file_exists($counterFile))
{
$fp = fopen($counterFile, "r+");
$count = fgets($fp,5);
$count += 1;
rewind($fp);
fputs($fp,$count,5);
fclose($fp);
}
?>

You seem to fopen the file with wrong mode.
"w" means writing only. I guess you want to read the count from the file and then increase it.

I hope what I told you will help you out.

/Fabbe

Anon

Well, I tried it thanks, but it didn't work.

Just get no output, using the file count.txt

$counterFile = "http://www.site.com/cgi-bin/count.txt";

also tried just

$counterFile = "count.txt";
which gives a whole load of "permission declined" and "Unable to find file identifier 0" errors.

I also tried changing

$count += 1;
to $count = +1;
dunno if that was a typo, either way doesn't work.

To get output I just put in echo "$count"; at the end, but no joy again.

Thanks for any feedback, don't know why I'm having so many problems with this supposedly easy function.

fabbe

I really can't understand the way you're trying to make this simple counter. Try using this:

// Full sys path to count.txt
$counter_file = 'count.txt';

//$counter_file = 'http://host/count.txt';
//by opening the file with http you can't
//write to it. you might wanna try ftp://
//instead or run it in the same directory
//for the easiest soloution.

// Puts the file lines into $counter_file_line array
$counter_file_line = file($counter_file);

// adds one to the number in the [0] array or the very first line
$counter_file_line[0]++;

// opends the file and then writes the new number and then closes it
$cf = fopen($counter_file, "w+");
//if you use w+ make sure you have the
//right permissions. otherwise use w
//and have the file created beforehand

fputs($cf, "$counter_file_line[0]");
fclose($cf);

// prints out the full count
echo $counter_file_line[0];

I just tried it and it works. Make sure you have all the right permissions.

/Fabbe

Anon

hi,
well for some distros(?) the '++' operator does not work properly.hence if one replaces the line :
counter_file_line[0]++;
with :
counter_file_line[0]=counter_file_line[0]+1;
then things work fine!
hope it helps