I'm not sure if this can be done.

[Anon]

This is a file upload question. The file uploads fine however, I want to copy the picture to a particular directory BUT call it whatever the user names name is.

Here's my coding:
<?PHP
if (Session_is_registered("CUserName"))
{
print "$CUserName<BR><BR>";

print ($userfile_name);

if(copy($userfile,"c:\\phpweb\pics\$CUserName.jpg"))
	{
	print ("<BR>Thank you, your picture has been saved and posted.<BR><BR>");
	}
else
	{
	print ("Error");
	}
unlink($userfile);
}

else
{
print "Please log out and re-login and try to upload your picture again<BR>";
print "If you continue to experience problems, please contact technical support at (INSERT EMAIL HERE)";
}
?>

Thanks for helping me out.
Kelly

[kparker]

What's your question? Is the above code working for you or not?

One obvious concern, since it appears that everybody's files are going into a single folder, is that subsequent files can overwrite earlier ones of the same name. But maybe that's not a problem in your particular situation.

[Anon]

No, the code is not working. I want to happen is for example: if my username is kelly THEN I want my picture to be called kelly.jpg

[polson]

So it is currently saving the file, right? If so, what is it currently saving it as? Like, if username is kelly and kelly uploads a file, what is the kellys file currently saving as?

[Anon]

The name of thefile is whatever the name of the jpg is. So if the name of the picture is newyears.jpg - it stays newyears.jpg - it doesn't get renamed to kelly.jpg.

Thanks,
Mike

[kparker]

Well, I do see something wrong, now that I look back at it, but it doesn't seem that this would cause the particular misbehavior you are actually seeing:

You give the destination argument to copy() as:

&nbsp;&nbsp;"c:\phpweb\pics\$CUserName.jpg"

but clearly that second and third backslash should be doubled, too:

&nbsp;&nbsp;"c:\phpweb\pics\$CUserName.jpg"

BTW, Windows (and even DOS before it) was perfectly happy to use forward slashes in filenames; it's only command.com and (alas) cmd.exe that insists that the path-component separator be a backslash. So if you are sure that the variable will never be passed as an argument to system(), exec(), etc, then
go ahead and say:

&nbsp;&nbsp;"c:/phpweb/pics/$CUserName.jpg"

Less chance of this particular error happening. :-)

[Anon]

Hmm. I've taken your suggestion and it still isn't working. Instead I get the following error:

Warning: Unable to open '' for reading: Permission denied in c:\phpweb/fuploadconfirm.php on line 15
Error
Warning: Unlink failed (No such file or directory) in c:\phpweb/fuploadconfirm.php on line 31

Where Line 15 is:
if(copy($userfile,"c:/phpweb/userpics/$CUserName.jpg"))

AND

Line 31 is:
unlink($userfile)

Kirk Parker wrote:

Well, I do see something wrong, now that I look back at it, but it doesn't seem that this would cause the particular misbehavior you are actually seeing:

You give the destination argument to copy() as:

&nbsp;&nbsp;"c:\phpweb\pics\$CUserName.jpg"

but clearly that second and third backslash should be doubled, too:

&nbsp;&nbsp;"c:\phpweb\pics\$CUserName.jpg"

BTW, Windows (and even DOS before it) was perfectly happy to use forward slashes in filenames; it's only command.com and (alas) cmd.exe that insists that the path-component separator be a backslash. So if you are sure that the variable will never be passed as an argument to system(), exec(), etc, then
go ahead and say:

&nbsp;&nbsp;"c:/phpweb/pics/$CUserName.jpg"

Less chance of this particular error happening. :-)