Can't get info into database

Anon

I am having trouble debugging my php. I have written a page to add info to a database but it doesn't add the info. This isn't my first php page that does exactly this, but I can't quite figure this one out. I would appreciate any help, here is the code.

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2 FINAL//EN">

<HEAD>
<META HTTP-EQUIV="Content-Type" CONTENT="text/html; charset=ISO-8859-1">
<META NAME="Generator" CONTENT="">
<TITLE>Data Entry</TITLE>
</HEAD>
<BODY BGCOLOR="#FFFFFF" LINK="#0000FF" VLINK="#800080" TEXT="#000000" TOPMARGIN=0 LEFTMARGIN=0 MARGINWIDTH=0 MARGINHEIGHT=0>
<?php

                         if ($submit) {

                                 if (!$jobtype || !$jobtitle || !$dept || !$workhours || !$possitionsavail || !$jobdesc || !$jobreq) {

                                         echo "Sorry! You didn't fill in all the required fields!"; die;

                                 } else {

                                         // process form

                                         echo "Thank You!";

                                 }


                                }

<?php

$db = mysql_connect("localhost", "root") or die("Couldn't Connect.");

mysql_select_db("hprhs",$db) or die("Couldn't Select.");

if ($submit) {

// here if no ID then adding else we're editing

$sql = "INSERT INTO joblist (date,jobtype,hourtype,jobtitle,dept,workhours,possitionavail,jobstatus,jobdesc,jobreq) VALUES ('$date','$jobtype','$hourtype','$jobtitle','$dept','$workhours','$possitionavail','$jobstatus','$jobdesc','$jobreq')";

// run SQL against the DB

$result = mysql_query($sql);

echo "Record updated/edited!<p>";

print("<A HREF=data_entry.php>");

print("<B>Add A New Job</B></a>");
die;

} elseif ($delete) {

    // delete a record

$sql = "DELETE FROM calendar WHERE id=$id";

$result = mysql_query($sql);

echo "$sql Record deleted!<p>";

} else {

// this part happens if we don't press submit

}

$date=date('m/d/Y')

<P>

<?php

if ($id) {

// editing so select a record

$sql = "SELECT * FROM calendar WHERE id=$id";

$result = mysql_query($sql);

$myrow = mysql_fetch_array($result);

$id = $myrow["id"];

$month = $myrow["month"];

$day = $myrow["day"];

$time = $myrow["time"];

$year = $myrow["year"];

$purpose = $myrow["purpose"];

$comments = $myrow["comments"];

$attendees = $myrow["attendees"];

$location = $myrow["location"];



// print the id for editing



?>

<?
}
?>

<TABLE BORDER=0 CELLSPACING=0 CELLPADDING=0 WIDTH=563 NOF=LY>
    <TR VALIGN=TOP ALIGN=LEFT>
        <TD WIDTH=85 HEIGHT=48><IMG SRC="../General/clearpixel.gif" WIDTH=85 HEIGHT=1 BORDER=0></TD>
        <TD WIDTH=478><IMG SRC="../General/clearpixel.gif" WIDTH=478 HEIGHT=1 BORDER=0></TD>
    </TR>
    <TR VALIGN=TOP ALIGN=LEFT>
        <TD></TD>
        <TD WIDTH=478><P ALIGN=CENTER><B><FONT SIZE="+1">Employment Data Entry</FONT></B></TD>
    </TR>
</TABLE>
<TABLE CELLPADDING=0 CELLSPACING=0 BORDER=0 WIDTH=627>
    <TR VALIGN=TOP ALIGN=LEFT>
        <TD>
            <TABLE BORDER=0 CELLSPACING=0 CELLPADDING=0 WIDTH=533 NOF=LY>
                <TR VALIGN=TOP ALIGN=LEFT>
                    <TD WIDTH=15 HEIGHT=23><IMG SRC="../General/clearpixel.gif" WIDTH=15 HEIGHT=1 BORDER=0></TD>
                    <TD WIDTH=518><IMG SRC="../General/clearpixel.gif" WIDTH=518 HEIGHT=1 BORDER=0></TD>
                </TR>
                <TR VALIGN=TOP ALIGN=LEFT>
                    <TD></TD>
                    <TD WIDTH=518><P ALIGN=LEFT><B><FONT SIZE="+1">Job Data Entry |&nbsp; Edit |&nbsp; Removal | Search</FONT></B></TD>
                </TR>
            </TABLE>
        </TD>
        <TD>
            <TABLE BORDER=0 CELLSPACING=0 CELLPADDING=0 WIDTH=94 NOF=LY>
                <TR VALIGN=TOP ALIGN=LEFT>
                    <TD WIDTH=21 HEIGHT=21><IMG SRC="../General/clearpixel.gif" WIDTH=21 HEIGHT=1 BORDER=0></TD>
                    <TD WIDTH=73><IMG SRC="../General/clearpixel.gif" WIDTH=73 HEIGHT=1 BORDER=0></TD>
                </TR>
                <TR VALIGN=TOP ALIGN=LEFT>
                    <TD></TD>
                    <TD WIDTH=73><P><A HREF="../Index/index.html">Search</A></TD>
                </TR>
            </TABLE>
        </TD>
    </TR>
</TABLE>
<TABLE BORDER=0 CELLSPACING=0 CELLPADDING=0 NOF=LY>
    <TR VALIGN=TOP ALIGN=LEFT>
        <TD WIDTH=6 HEIGHT=11><IMG SRC="../General/clearpixel.gif" WIDTH=6 HEIGHT=1 BORDER=0></TD>
        <TD></TD>
    </TR>
    <TR VALIGN=TOP ALIGN=LEFT>
        <TD></TD>
        <TD WIDTH=637>
            <FORM NAME="Table1FORM" METHOD=POST ACTION="<? echo $PHP_SELF ?>">






                <TABLE ID="Table1" BORDER=0 CELLSPACING=1 CELLPADDING=1 WIDTH=637>
                    <TR>
                        <TD VALIGN=TOP ALIGN=RIGHT WIDTH=180><P>Date Entered <FONT COLOR="#FF3300">*</FONT> :</TD>
                        <TD COLSPAN=2 VALIGN=TOP><P><INPUT ID="FormsEditField6" TYPE=TEXT NAME="date" VALUE="<? echo $date ?>"  SIZE=10 MAXLENGTH=10>Format: 00/00/2000</TD>
                    </TR>
                    <TR>
                        <TD VALIGN=TOP ALIGN=RIGHT WIDTH=180><P>Job Category <FONT COLOR="#FF3300">*</FONT> :</TD>
                        <TD VALIGN=TOP WIDTH=165><P>
                        <select name="jobtype">
                        	<option value="General Opportunities">General Opportunities</option>
                        	<option value="Professional/Technical">Professional/Technical</option>
                        	<option value="Staff RN">Staff RN</option>
                        	<option value="Nursing Assistants">Nursing Assistants</option>
                        	<option value="Management">Management</option>
                        	<option value="Unit Coordinators">Unit Coordinators</option>
                        	<option value="Unit Secretary">Unit Secretary</option>
                        	</select>


                            &nbsp;</TD>
                        <TD VALIGN=TOP WIDTH=282><P>
                            <SELECT NAME="hourtype">
                                <OPTION VALUE="Full Time">Full Time</OPTION>
                                <OPTION VALUE="Part Time">Part Time</OPTION>
                                <OPTION VALUE="PRN">PRN</OPTION>
                            </SELECT>
                            &nbsp;</TD>
                    </TR>
                    <TR>
                        <TD VALIGN=TOP ALIGN=RIGHT WIDTH=180><P>Job Title <FONT COLOR="#FF3300">*</FONT> :</TD>
                        <TD COLSPAN=2 VALIGN=TOP><P><INPUT ID="FormsEditField2" TYPE=TEXT NAME="jobtitle" VALUE="<? echo $jobtitle ?>" SIZE=50 MAXLENGTH=50>&nbsp;</TD>
                    </TR>
                    <TR>
                        <TD VALIGN=TOP ALIGN=RIGHT WIDTH=180><P>Dept # <FONT COLOR="#FF3300">*</FONT> : </TD>
                        <TD COLSPAN=2 VALIGN=TOP><P><INPUT ID="FormsEditField3" TYPE=TEXT NAME="dept" VALUE="<? echo $dept ?>" SIZE=10 MAXLENGTH=10>&nbsp;</TD>
                    </TR>
                    <TR>
                        <TD VALIGN=TOP ALIGN=RIGHT WIDTH=180><P>Work Hours <FONT COLOR="#FF3300">*</FONT> : </TD>
                        <TD COLSPAN=2 VALIGN=TOP><P><INPUT ID="FormsEditField5" TYPE=TEXT NAME="workhours" VALUE="<? echo $workhours ?>" SIZE=50 MAXLENGTH=50>&nbsp;</TD>
                    </TR>
                    <TR>
                        <TD VALIGN=TOP ALIGN=RIGHT WIDTH=180><P>Salary Range : </TD>
                        <TD COLSPAN=2 VALIGN=TOP><P><INPUT ID="FormsEditField4" TYPE=TEXT NAME="salaryrange" VALUE="<? echo $salaryrange ?>" SIZE=50 MAXLENGTH=50>&nbsp;</TD>
                    </TR>
                    <TR>
                        <TD VALIGN=TOP ALIGN=RIGHT WIDTH=180><P># Positions Available <FONT COLOR="#FF3300">*</FONT> : </TD>
                        <TD COLSPAN=2 VALIGN=TOP ALIGN=LEFT><P><INPUT ID="FormsEditField7" TYPE=TEXT NAME="possitionsavail" VALUE="<? echo $possitionsavail ?>" SIZE=2 MAXLENGTH=2>&nbsp;</TD>
                    </TR>
                    <TR>
                        <TD VALIGN=TOP ALIGN=RIGHT WIDTH=180><P>Current Status : </TD>
                        <TD COLSPAN=2 VALIGN=TOP><P>
                            <SELECT NAME="jobstatus">
                                <OPTION VALUE="Active">Active</OPTION>
                                <OPTION VALUE="Inactive">Inactive</OPTION>
                            </SELECT>
                            &nbsp;= it will show in public web search</TD>
                    </TR>
                    <TR>
                        <TD ALIGN=RIGHT WIDTH=180><P>Job <FONT COLOR="#FF3300">* <BR></FONT>Description : </TD>
                        <TD COLSPAN=2><P><TEXTAREA WRAP=PHYSICAL ID="FormsMultiLine1" NAME="jobdesc" ROWS=13 COLS=50 VALUE="<? echo $jobdesc ?>"></TEXTAREA>&nbsp;</TD>
                    </TR>
                    <TR>
                        <TD ALIGN=RIGHT WIDTH=180><P>Job <FONT COLOR="#FF3300">* <BR></FONT>Requirements : </TD>
                        <TD COLSPAN=2><P><TEXTAREA WRAP=PHYSICAL ID="FormsMultiLine2" NAME="jobreq" ROWS=13 COLS=50 VALUE="<? echo $jobreq ?>"></TEXTAREA>&nbsp;</TD>
                    </TR>
                    <TR>
                        <TD COLSPAN=3><P>All entries with <FONT COLOR="#FF3300">*</FONT> are required.</TD>
                    </TR>
                    <TR>
                        <TD ALIGN=CENTER WIDTH=180><P><INPUT TYPE=SUBMIT NAME="submit" VALUE="Save It" ID="FormsButton1"><INPUT TYPE=RESET NAME="FormsButton8" VALUE="Reset" ID="FormsButton8">&nbsp;</TD>
                        <TD COLSPAN=2>&nbsp;</TD>
                    </TR>
                </TABLE>
            </FORM>
        </TD>
    </TR>
</TABLE>

</BODY>

Anon

I also wanted to point out that I get no errors at all! It just doesn't update the MySQL database.

sfarris

Are you certain that in $sql that all of the field names are in the same order as in the database?

$sql = "INSERT INTO joblist (date,jobtype,hourtype,jobtitle,dept,workhours,possitionavail,jobstatus,jobdesc,jobreq) VALUES ('$date','$jobtype','$hourtype','$jobtitle','$dept','$workhours','$possitionavail','$jobstatus','$jobdesc','$jobreq')";

If you specify no column list for INSERT ... VALUES or INSERT ... SELECT, values for
all columns must be provided in the VALUES() list or by the SELECT. If you don't know
the order of the columns in the table, use DESCRIBE tbl_name to find out. (MySQL Manual)

I am not quite an expert yet, but everything else in that section of your code looks just like code that I am working on right now that is working for me.

If this does work, would you mind letting me know? This is my first time to reply to someone else's post (and the Lord knows that I have picked up quite a bit of help off of this forum).

Thanks

Anon

Thank you for your help, the problem was a missing field (oops 😉) and one misspelling (possitionsavail, not possitionavail). Your advice on the fields being in the right order put me on the right track.

Anon

the reason you weren't getting an error is because you didn't add the 'on die ("INSERT UNSUCCESSFUL")' on your mysql_query line. Then you would get at least that when it didn't work.

craig