Help! Stuck in an infinite loop!!!!!!!!!

Anon

I'm basically just trying to do a search based on a single criteria. I believe the query is ok but it only prints the first result. My thinking was then to put this through a loop and maybe i'll get all the results - not just the one result.
It'll be easier to explain what i'm doing if I include the code (see below):

//This queries others with the same interests
$query = "SELECT CFirstName, CLastName, CCity, CEmail FROM clients,interests WHERE I1 = '$Interests' OR I2 = '$Interests' OR I3 = '$Interests' OR I4 = '$Interests' OR I5 = '$Interests' OR I6 = '$Interests' OR I7 = '$Interests'";
$result = mysql_query($query);
$row = mysql_fetch_object($result);

//This is used to query the total number of rows in the database
$id = "SELECT CID FROM clients";
$resultid = mysql_query($id);
$num_rows = mysql_num_rows($resultid);
print "There are currently $num_rows in the database ";

//This loops through the database and prints the results
$loopvar=0;
for ($loopvar=0; $loopvar=$num_rows; $loopvar++)
{
print "$row->CFirstName $row->CLastName $row->CEmail $row->CCity ";
}

Anyone help out a newbie with PHP?

Thanks,
Mike

brandonschnell

try this. haven't tested it tho.

$query = "SELECT CFirstName, CLastName, CCity, CEmail FROM clients,interests WHERE I1 = '$Interests' OR I2 = '$Interests' OR I3 = '$Interests' OR I4 = '$Interests' OR I5 = '$Interests' OR I6 = '$Interests' OR I7 = '$Interests'";
$result = mysql_query($query);

//This is used to query the total number of rows in the database
$resultid = mysql_query("SELECT count(*) FROM clients");
$num_rows = mysql_fetch_array($resultid);
print "There are currently $num_rows[0] in the database ";

//This loops through the database and prints the results
while($row = mysql_fetch_array($result))
{
print "$row->CFirstName $row->CLastName $row->CEmail $row->CCity ";
}

staffanolin

It should be mysql_fetch_object($result)
instead of ...fetch_array($result)
in while(...) !
(I assume)

/Staffan

Anon

for ($loopvar=0; $loopvar=$num_rows; $loopvar++)

...

Shouldn't that be:

for ($loopvar=0; $loopvar < $num_rows; $loopvar++)

Anon

John has pointed out rightly , in your coding for loop you asssigned the value of $loopvar to $num_rows rather than putting a condition like < $num_rows

Anon

Ok, that was stupid mistake on mypart. I've made the changes. HOWEVER, I have results that meet the same search criteria but instead of printing a list of names. It prints the same name (which is the first applicable record in the database a bunch of times).

The updated coding is as follows:
//This queries others with the same interests
$query = "SELECT CFirstName, CLastName, CCity, CEmail FROM clients,interests WHERE I1 = '$Interests' OR I2 = '$Interests' OR I3 = '$Interests' OR I4 = '$Interests' OR I5 = '$Interests' OR I6 = '$Interests' OR I7 = '$Interests'";
$result = mysql_query($query);
$row = mysql_fetch_object($result);

//This is used to query the total number of rows in the database
$id = "SELECT CID FROM clients";
$resultid = mysql_query($id);
$num_rows = mysql_num_rows($resultid);

for ($loopvar=0; $loopvar<$num_rows; $loopvar++)
{
print "$row->CFirstName &nbsp $row->CLastName    $row->CEmail    $row->CCity ";
}

brandonschnell

look at your loop, you're incrementing for every row but you're not loading a new row of data. you need to call mysql_fetch_object before showing a new row. look at what i posted previously for an easier way to do this.

Anon

Sorry but I can't find Brandon's old posting and i've put the query inside the loop but the result is still the same. I'm not quite sure how to increment to the next item rather than printing the same thing over and over again. Here's the code:

//This is used to query the total number of rows in the database
$id = "SELECT CID FROM clients";
$resultid = mysql_query($id);
$num_rows = mysql_num_rows($resultid);

//Loops through the database and print the results of query
for ($loopvar=0; $loopvar<$num_rows; $loopvar++)
{
//This queries others with the same interests
$result = mysql_query($query);
$row = mysql_fetch_object($result);
print "$row->CFirstName $row->CLastName    $row->CEmail    $row->CCity ";
}

Anon

close but no cigar.

look at <a href="http://www.phpbuilder.com/forum/read.php3?num=2&id=119812&thread=119811"> this </a> for my comments (change the bottom mysql_fetch_array to mysql_fetch_object).

below is my take on whats going on in your code:

//This is used to query the total number of rows in the database
###select all cid data from mysql and make it available to php
$id = "SELECT CID FROM clients";
$resultid = mysql_query($id);
###have php count the rows (you could do this in mysql using "select count(cid) from clients", probably faster for larger tables)
$num_rows = mysql_num_rows($resultid);

//Loops through the database and print the results of query
###loop for each row
for ($loopvar=0; $loopvar<$num_rows; $loopvar++)
{
//This queries others with the same interests
###run the query to fetch data returning the first row
$result = mysql_query($query);
###return the first row and set the cursor to the next row
$row = mysql_fetch_object($result);
print "$row->CFirstName $row->CLastName $row->CEmail $row->CCity ";
}

so its not looping because you're running the select and returning the first row every time through the loop. place "$result = mysql_query($query);" before the loop.