mysql_querry

big_e

I'm having some trouble puting data into a MySQL database. I'm trying to update existing data and I'm net getting any error messages but it doesn't do anything. Here is my code:

mysql_query ("INSERT INTO counterdata (name, email, url, password) VALUES ('$newname', '$newemail', '$newurl', '$newpass') WHERE username='$curuser' AND password='$curpass'");

It just isn't doing it. I've even tried UPDATE and REPLACE. I don't know what to do, thanks in advance for your help.

[deleted]

INSERT always creates a new record, so it cannot be used with the WHERE clause.

Use UPDATE to change data, but the format is much different from what you have here.

It looks like you need to read the MySQL manual about how to write queries:

http://www.mysql.com/doc/U/P/UPDATE.html

terje-s

What I find to be the most useful thing to do in this kind of situations is;

Instead of executing the query directly, store it in a variable (e.g. $sql = "INSERT INTO counterdata..."😉 and then print the query.

This could help you understand what goes wrong. If you can't see anything special, try to copy the query printed and paste it into the mysql frontend.

terje-s

Void the above message, ofcourse vincent is entirely correct.

[deleted]

thanks :-)

But your suggestion is completely correct.

9 out of 10 times a query doesn't work because it is created from strings and things go wrong with quotes, empty variables, typos in variable names etc.

Printing the finished query gives you a much better view of what is going on.

big_e

OK, I looked at the manual and I think I have it but it still isn't working for me *so maybe I don't have it...). Here is what I have now:

mysql_query ("UPDATE counterdata SET name=$newname, email=$newemail, url=$newurl, password=$newpass WHERE username='$curuser' AND password='$curpass'");

Maybe I'm just missing something... anyway, its frustrating so HELP! hah, thanks again.

big_e

OK! I got it! I had one minor technicality... big word... here is what I have now (and yes it works ;o)

mysql_query ("UPDATE counterdata SET name='$newname', email='$newemail', url='$newurl', password='$newpass' WHERE username='$curuser' AND password='$curpass'");

Anyway, thanks for all your help and I'l probably be back as I update another script, hah, THANKS!

~ Eric

Anon

See how easy it is once you read the manuals? :-) Have fun!