Calling a function in an if statement

Anon

I posted this once before, but messed up in my question (I was really, really tired!)

Could anyone tell me why I can never get a function to work inside an if statement? Is this a no-go or am I doing it wrong?

example:

if ($DIR != "entrance") {

echo ("<tr>\n\n
<td align=\"center\" valign=\"middle\" width=\"150\" height=\"25\" colspan=\"2\">\n") ;

thisSWF (thisSWF="entrance_hdr", thisWidth="150", thisHeight="25") ;

echo ("</td>\n\n
</tr>\n") ;

}

Thanks!
Eric

finger

thisSWF (thisSWF="entrance_hdr", thisWidth="150", thisHeight="25") ;

what should this do?

whats the problem? syntax-error? wrong
output?

regards

finger

ericw

This function places the code for embeddign a Flash movie (.swf) into a page. I've included the original function code below. You can see why I don't want to have to retype this every time I use a Flash movie.
This function works perfectly on it's own, but does not work inside an if statement. I keep getting a parse error.

//define thisSWF function //
function thisSWF () {
	global $thisSWF ;
	global $thisWidth ;
	global $thisHeight ;
	echo ("<object classid=\"clsid:D27CDB6E-AE6D-11cf-96B8-444553540000\" codebase=\"http://download.macromedia.com/pub/shockwave/cabs/flash/swflash.cab#version=5,0,0,0\" ID=\"" . $thisSWF . "\" width=\"" . $thisWidth . "\" height=\"" . $thisHeight . "\">\n<param name=\"Movie\" value=\"" . $thisSWF . ".swf\">\n<param name=\"Quality\" value=\"Best\">\n<param name=\"menu\" value=\"0\">\n<param name=\"Scale\" value=\"ShowAll\">\n<embed  width=\"" . $thisWidth . "\" height=\"" . $thisHeight . "\" src=\"" . $thisSWF . ".swf\" quality=\"best\" scale=\"ShowAll\" SWLIVECONNECT=\"true\" TYPE=\"application/x-shockwave-flash\" PLUGINSPAGE=\"http://www.macromedia.com/shockwave/download/index.cgi?P1_Prod_Version=ShockwaveFlash\">\n<noembed>\n<a href=\"http://www.macromedia.com/shockwave/download/index.cgi?P1_Prod_Version=ShockwaveFlash\">This site requires<br>Macromedia Flash.<br>Click here to get<br>the latest plug-in</a>\n</noembed>\n</object>\n") ;
}

Thanks,
Eric

kparker

You need to study a bit more on how functions work, and how to pass parameters to them.

The function needs to look like this:

   function thisSWF ( $thisSWF, $thisWidth, $thisHeight )
   {
   ...

and also get rid of the GLOBAL statements at the beginning of the function body; these are now parameters to the function.

Then, you call it like this:

   thisSWF( "entrance_hdr", "150", "25" );

ericw

Yeah, I feel like an incredible moron, I just noticed that myself.
Sorry!

edwardsbc

It is also good form to actually RETURN a value, even it is is only:

return true;

as the last line of your function.

(Why don't you breakup that echo line? That is nearly impossible to read/debug.)