php / javascript problems?

Anon

The php of the php/javascript code below dynamically fills the britishTowns array entries at the server and sends the array along with the rest of the javascript to the client to be further acted upon by the client.

britishTowns = new Array(
<?
while($row =@mysql_fetch_array($resultId))
{
$region=$row['region'];
?>
<? echo("'".$region."'".","); ?>

                    <? }?> 

                        'END');

However the javascript passed on to the client when executed on the client produces the following formatted code and the client doesn't like the closing comma on the next line and issues the warning 'unterminated string constant'. Why has the array been formatted like this?

britishTowns = new Array(
'ANGLIA1
',

'ANGLIA2
',

'LONDON
',

'MIDLANDS1
',

'END');

However by manipulating the resulting code on the client it is observed that if the formatting is changed as below the code as a whole executes as expected??
I thought javascript was a free formatting language??

britishTowns = new Array('ANGLIA1','ANGLIA2','LONDON','MIDLANDS1,'END');

Can i set up the php/javascript on the server to result in the javascript above on the client after execution of the php/javascript on the server??

please lend me your ears... should that be borrow all i can see at the moment is problems!
Oh Well!

adios.

Anon

It appears that there is a newline character in your $region, so you could try....

<? echo("'".chop($region)."',"); ?>

djcookie

just format your <? ?> tags so that the carriage returns are in the php code rather than in the javascript.

britishTowns = new Array(<?
while($row =@mysql_fetch_array($resultId)) {
$region=$row['region'];
echo("'".$region."'".",");
}?>'END');

ps. formatting may look a bit weird coming out of this html form.

Anon

thankyou very much chad for your suggestion i am extremely grateful that you took the time to respond and it worked a treat.

my php book from wrox press doesn't mention this function although carriage return problem was suspected (tongue in cheek)

your a star chad have a very nice day

paul.

Anon

I was thinking this exact same thing at first, but then saw that the new line was in the middle of the echo statement. In the senario you're talking about, a new line would have been at the end of the echo statement.

djcookie

good eye. i missed that...

Anon

Hi Chad

what causes this carriage return in my code?

paul

Anon

My guess is that when you captured the data, it placed the newline in there.

As example, if you read a file in to populate your database, and the field was either the only or last entry on a line, it might have included the newline characters with the field. When I populate a dabase with data from a text file (using perl), I have to read the line in and then chomp it (perl chomp is similar to php chop) before I split the fields out.

If someone was entering the data, they may have hit the enter key at the end of the data.