lots of code

big_e

OK, I have a program that has checkboxes that look like this:

When the form is submited, my script does a mysql query that looks like this (after login of course):

$result=mysql_query("SELECT number FROM $username");
while($row=mysql_fetch_array($result)){
if($row[0] == "yes"){
mysql_query("DELETE FROM $username WHERE number='$row[0]'") or die ("Can't Delete Entry");
}
}

In my thinking, this would delete row 5 if the checkbox is checked, but it doesn't. Any ideas?

~ Eric
123 Make Me! ( http://123-makeme.com )

[deleted]

Arny errors?
In SQL statements, you usually don't put quotes around numbers.

big_e

WAIT!!! hahahahhaha, I'm an idiot! ok, here's what happned!

that doesn't work because if says:

if(5 == "yes")

when it needs to say:

if($5 == "yes")

so duh! change it to:

if($$row[0] == "yes")

I'm an idiot! it works now! Hah, thanks anyway!

~ Eric
123 Make Me! ( http://123-makeme.com )

kparker

Well, it's more complicated than just that. Look at his code again:

  $result=mysql_query("SELECT number FROM $username");
  // LOOK, the column it's asking for is 'number'
  while($row=mysql_fetch_array($result))
  {
  if($row[0] == "yes")
  // now it's expecting this column called 'number'
  // to have a text value "yes"???

It seems to me there is some basic confusion here about what's data in the database and what's coming from form variables. For starters, if you want to be able to update or remove a single unique row from the database, you absolutely have to have some kind of unique identifier (a.k.a. primary key) for the table. So for example, if you wanted to delete something based on the value of a column, it's not enough to fetch the column of interest, you also have to retrieve the key column:

  $locate_qry = "select unique_id,column from $username";
  ...
  if (...)
   mysqy_query("delete from $username where unique_id = $row[0]");

I also suspect there's a problem with your checkbox, in particular with the <b>name="5"</b> part. PHP is not going to be able to turn that into a variable since its name would by "5" and that's not going to fly. The best I have been able to do in similar cases is name it something like "delete_nnn" where "nnn" represents the primary key, and then parse off the "nnn".