Parse Error for NEWBY?

lorends

I get a Parse error on line 165 below. How do I correct it?
161 $siteaddress","FROM:$adminaddress");
162
163 IF ($logging=="yes") {
164 }
165 NewSite="vmlog.txt";
166
167 // Nothing needs to be changed here
168 $fl=fopen(NewSite,"a+");
169 // sets the pipe delimiters
170 fwrite($fl,"$fname,$lname,$vemail,$comments\n");
171 fclose($fl);

staffanolin

NewSite should probably have a $ in the beginning ($NewSite) as it is a variable

/Staffan

phillip

yes, and don't forget the $ on line 168, too.
or if you want NewSite to be a constant, do:

define("NewSite","vmlog.txt");

[...]
165 NewSite="vmlog.txt";
166
167 // Nothing needs to be changed here
168 $fl=fopen(NewSite,"a+");

lorends

Still getting the following error:
Parse error in the file on my server called contact_me_now.php on line 163
This is the PHP file.

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN"><HEAD><META HTTP-EQUIV="Content-Type" CONTENT="text/html; charset=ISO-8859-1"><TITLE>contact me</TITLE></HEAD><BODY BGCOLOR="#FFFFFF" TEXT="#000000" LINK="#000000" VLINK="#990033" ALINK="#000000" TOPMARGIN=0 LEFTMARGIN=0 MARGINWIDTH=0 MARGINHEIGHT=0><TABLE CELLPADDING=0 CELLSPACING=0 BORDER=0 WIDTH=736 NOF=LY><TR VALIGN=TOP ALIGN=LEFT><TD><TABLE BORDER=0 CELLSPACING=0 CELLPADDING=0 NOF=LY><TR VALIGN=TOP ALIGN=LEFT><TD WIDTH=10
HEIGHT=90><IMG SRC="../../clearpixel.gif" WIDTH=10 HEIGHT=1 BORDER=0></TD><TD></TD></TR><TR VALIGN=TOP ALIGN=LEFT><TD></TD><TD WIDTH=135><TABLE ID="Table1" BORDER=0 CELLSPACING=0 CELLPADDING=1 WIDTH="100%"><TR><TD WIDTH=133 BGCOLOR="#CCCCFF"><TABLE BORDER=0 CELLSPACING=0 CELLPADDING=7 WIDTH=133 NOF=TI><TR><TD><P><A HREF="../../index.html"><B><FONT SIZE="+1">Home</FONT></B></A></P></TD></TR></TABLE></TD></TR><TR><TD WIDTH=133 BGCOLOR="#CCCCFF"><TABLE BORDER=0 CELLSPACING=0 CELLPADDING=7
WIDTH=133 NOF=TI><TR><TD><P><A HREF="../../About_Loren/about_loren.html"><FONT SIZE="-1">About Loren</FONT></A></P></TD></TR></TABLE></TD></TR></TABLE></TD></TR></TABLE></TD><TD><TABLE BORDER=0 CELLSPACING=0 CELLPADDING=0 WIDTH=591 NOF=LY><TR VALIGN=TOP ALIGN=LEFT><TD WIDTH=33 HEIGHT=67><IMG SRC="../../clearpixel.gif" WIDTH=33 HEIGHT=1 BORDER=0></TD><TD></TD></TR><TR VALIGN=TOP ALIGN=LEFT><TD HEIGHT=37></TD><TD WIDTH=558>
<?

// Enter your email address here
$adminaddress = "lorends@pacbell.net";

// Enter the address of your website here MUST include http://www.
$siteaddress ="http://www.coastalhomefinder.com";

// Enter your company name or site name here
$sitename = "Coastal Home Finder";

// Enter your page title here
$ptitle = "For answers to questions just fill in the form";

// Colour/Style Values for your page - hexy!
//Background Colour
$bgcolor = "#ffffff";

//Table Border
$bocolor = "#3300cc";

// Font Colour
$fcolor = "#444444";

// Link Colour
$lcolor = "#ff0000";

// Font Style
$font = "verdana";

// Font Size
$fontsize = "3";

// Loren's email log set to "no" to disable
$logging="yes";

// Unless you know better I advise that you don't touch anything below here!
// Don't touch this it grabs the date and time from your server
$date = date("m/d/Y H:i:s");
$vers = "VinceMail V1.1";
$traceroute = "<a href=\"http://www.above.net/cgi-bin/trace?$REMOTE_ADDR\">";

if ($REMOTE_ADDR == "") $ip = "<i> no ip </i>";
else $ip = getHostByAddr($REMOTE_ADDR);

IF ($action==""):
?>

<head><title><? echo "$ptitle"; ?></title>
<body bgcolor="<? echo "$bgcolor"; ?>" Link="<? echo "$lcolor"; ?>" vLink="<? echo "$lcolor"; ?>">
<center>

<FORM name=validation METHOD=POST ACTION="<? echo "$PHP_SELF"; ?>" onSubmit="return checkbae()">
<TABLE BORDER="0" CELLSPACING="0" CELLPADDING="2" width=50% bgcolor="<? echo "$bocolor"; ?>">
<TR>
<TD VALIGN="TOP">
<center><TABLE BORDER="0" CELLSPACING="0" CELLPADDING="3" width=100% bgcolor="<? echo "$bgcolor"; ?>">
<TR>
<TD VALIGN="TOP" colspan=2><font face="<? echo "$font"; ?>" size="<? echo "$fontbig"; ?>" color="<? echo "$fcolor"; ?>"><b><? echo "$ptitle"; ?></b></FONT></TD>
</TR>
<TR>
<TD VALIGN="TOP"><font face="<? echo "$font"; ?>" size="<? echo "$fontsize"; ?>" color="<? echo "$fcolor"; ?>"><small>Your First Name:</FONT></TD>
<TD VALIGN="TOP"><INPUT TYPE="text" NAME="fname"></FONT></TD>
</TR>
<TR>
<TD VALIGN="TOP"><font face="<? echo "$font"; ?>" size="<? echo "$fontsize"; ?>" color="<? echo "$fcolor"; ?>"><small>Your Last Name:</FONT></TD>
<TD VALIGN="TOP"><INPUT TYPE="text" NAME="lname"></FONT></TD>
</TR>
<TR>
<TD VALIGN="TOP"><font face="<? echo "$font"; ?>" size="<? echo "$fontsize"; ?>" color="<? echo "$fcolor"; ?>"><small>Your Email:</FONT></TD> <TD VALIGN="TOP"><INPUT TYPE="text" NAME="vemail"></FONT></TD> </TR>
<TR>
<TD VALIGN="TOP"><font face="<? echo "$font"; ?>" size="<? echo "$fontsize"; ?>" color="<? echo "$fcolor"; ?>"><small>Tel no:</FONT></TD> <TD VALIGN="TOP"><INPUT TYPE="text" NAME="telno"></FONT></TD> </TR>

<TR>
<TD VALIGN="TOP" COLSPAN="2"><font face="<? echo "$font"; ?>" size="<? echo "$fontsize"; ?>" color="<? echo "$fcolor"; ?>"><small>Additional Comments:</FONT></TD> </TR>

var testresults

function checkemail(){

var str=document.validation.vemail.value

var filter=/^{.+@.+..{2,3}$/}

if (filter.test(str))

testresults=true

else{

alert("Please input a valid email address!")

testresults=false

}

return (testresults)

}

</script>
<script>

function checkbae(){

if (document.layers||document.all)

return checkemail()

else

return true

}

</script>

<?
//This grabs the form data and formats it and sends it in an email to you

exit;
ELSEIF ($action="Send"):
mail("$adminaddress","Info Request", "FAO: Admin @ $sitename \n
First Name: $fname
Last Name: $lname
Email: $vemail
Telephone: $telno\n

The visitor commented:

$comments

Logged Info :

Mailer: $vers
Using: $HTTP_USER_AGENT
Hostname: $ip
IP address: $REMOTE_ADDR
Date/Time: $date","FROM:$adminaddress");

//This grabs the form data and sends a confirmation to your visitor

mail("$vemail","Thank You for visiting $sitename", "Hi $fname,\n
Thank you for your interest in $sitename!
We will read your comments as soon as we can and act accordingly.
You can expect a response within 12hrs.\n
Best regards,
$sitename
$siteaddress","FROM:$adminaddress");

$siteaddress","FROM:$adminaddress");

//Error is supposed to be in this area of the script
IF ($logging=="yes") {
}
define(NewSite="vmlog.txt");
// Nothing needs to be changed here
$fl=fopen(NewSite,"a+");
// sets the pipe delimiters
fwrite($fl,"$fname,$lname,$vemail,$comments\n");
fclose($fl);

//Error above this line

PRINT "<head><title> $ptitle </title><body bgcolor=\"$bgcolor\" Link=\"$lcolor\" vLink=\"$lcolor\"><CENTER>";
PRINT "<TABLE BORDER=\"0\" CELLSPACING=\"0\" CELLPADDING=\"3\" width=\"60%\" bgcolor=\"$bocolor\">";
PRINT "<TR><TD VALIGN=\"TOP\">";
PRINT "<TABLE BORDER=\"0\" CELLSPACING=\"0\" CELLPADDING=\"3\" width=\"100%\" bgcolor=\"$bgcolor\">";
PRINT "<TR><TD VALIGN=\"TOP\"><font face=\"$font\" color=\"$fcolor\"><small>Hello, $fname.";
PRINT "<BR><BR>";
PRINT "<font face=\"$font\" color=\"$fcolor\">Thank you for your completing our form.<BR><BR>";
PRINT "<font face=\"$font\" color=\"$fcolor\">We will send information to<b> $vemail </b>, within 12hrs.<br>";
PRINT "<font face=\"$font\" color=\"$fcolor\">To return to our homepage [<A href=\"$siteaddress\">Click Here</A>]";
PRINT "</CENTER></td></TR></TABLE></td></TR></TABLE>";
ENDIF;
?>
</TD>
</TR></TABLE></TD></TR></TABLE></BODY>

phillip

Hi Loren,

fixed your code.
You used the define() function in a wrong way. Also you had duplicated a part of a mail function call which produced another parse error.

Just swap the code snippet below for the buggy stuff in your php.

In general, if I have to put together longer email messages, i assemble the 'body' as a seperate variable - changed that below, too. Makes the code more legible.

Hope it'll work now.
Phil!

//This grabs the form data and sends a confirmation to your visitor

$body = "Hi $fname,\nThank you for your interest in $sitename!\nWe will read your comments as soon as we can and act accordingly.\nYou can expect a response within 12hrs.\n\nBest regards,\n$sitename\n$siteaddress";

mail("$vemail","Thank You for visiting $sitename",$body,"FROM:$adminaddress");

//Error is supposed to be in this area of the script
// not anymore !
IF ($logging=="yes") {
}
define("NewSite","vmlog.txt");
// Nothing needs to be changed here
$fl=fopen("NewSite","a+");
// sets the pipe delimiters
fwrite($fl,"$fname,$lname,$vemail,$comments\n");
fclose($fl);

//Error above this line