While loops, two ways, both parse errors

[Anon]

I've cut the below down as much as possible, I'm trying to echo the results from a table as values in a form, now, this works, but whatever I do it generates an annoying parse error, if anyone can help me eliminate that I'd appreciate it.

I have looked at the manual and tried both ways, the other being brackets, opening at the : and closing before or after (ie tried both ways) the endwhile;

Nothing seems to work!

$recruiter is chosen from a different form above to select which record to display.

$submitid is the name of the previous form

<?php
if ($submitid)
{
include "connect.inc";
$accept=mysql_query("SELECT * FROM tablename WHERE id=$recruiter",$db);
while($mrows=mysql_fetch_array($accept)):
?>

<form action="<?php echo($PHP_SELF); ?>" method=post>
<table border="0" cellspacing="0" cellborder="0">
<tr>
<td bgcolor="a0c544">First Name:&nbsp;&nbsp;&nbsp;</td><td><input type="text" name="firstname" size="15" maxlength="20" value="<?php echo $mrows["firstname"] ?>"></td>
</table>
<br>
<input type="submit" name="submit" value="submit">
</form>

<?php
endwhile;
?>

Thanks a lot for any help!

[terje-s]

while (criteria) {
// do stuff
}

[terje-s]

Oops, maybe I should explain a couple of things.. 🙂

while (criteria);

loops until critera is false. This will not execute the desired code for each row fetched from the database. This type of while loop is well suited to read data into an array. E.g.:

while ($lines[] = fgets($fp, 4096));

It is not, on the other hand, suited to print one form for each line read (or row fetched, depending on the situation.)

while ($line = fgets($fp, 4096)) {
// manipulate $line in some way
print $line;
}

[Anon]

I tried the ; way and found it didn't work before.

For your first post, I tried

while($mrows=mysql_fetch_array($accept)) {

do stuff here

}

that as well as I'd said, but it gave the same error!

[Anon]

At the end,

<?php
}
}
?>

works, helps if I end BOTH sets of brackets!

doh! Nearly as stupid as trying to debug the file when I was connected to the wrong server!