updating mysql tables

[Anon]

Does anyone have any idea what might be wrong with the following script, it keeps bringing up this error:

You have an error in your SQL syntax near 'email = '[e-mail]' WHERE ID = '1'' at line 1

Heres the script:

$result = mysql_query("SELECT username,password,realname,ranker,rank,bnetwins,bnetlosses,b
netdisconnects,icq,aolim,email,joinTS,loginTS,ID FROM Users") or die (mysql_error());

// read everything into an array
while (list($username,$pass,$realname,$ranker,$rank,$bnetwins,$bne
tlosses,$bnetdisconnects,$icq,$aolim,$email,$joinTS,$loginTS
,$ID) = mysql_fetch_row($result)) {
$username_array[] ="$username";
$password_array[] ="$pass";
$realname_array[] ="$realname";
$ranker_array[] ="$ranker";
$rank_array[] ="$rank";
$bnetwins_array[] ="$bnetwins";
$bnetlosses_array[] ="$bnetlosses";
$bnetdisconnects_array[]="$bnetdisconnects";
$icq_array[] ="$icq";
$aolim_array[] ="$aolim";
$email_array[] ="$email";
$joinTS_array[] ="$joinTS";
$loginTS_array[] ="$loginTS";
$ID_array[] ="$ID";
}
mysql_close();

$result = MYSQL_QUERY("UPDATE Users SET realname = '$change_realname', bnetwins = '$change_bnetwins', bnetlosses = '$change_bnetlosses', bnetdisconnects = '$change_bnetdisconnects', icq = '$change_icq', aolim = '$change_aolim' email = '$change_email' WHERE ID = '$ID_array[$userid]'") or die(mysql_error());

[jc94062]

The below shouldn't work...

<i>$username_array[] ="$username";</i>

In my experience the variable you want to set has to be first...

<i>$username = $username_array[];</i>

That may help, I know things like

<i>$mrows["zonename"] = $zone;</i> don't work while
<i>$zone = $mrows["zonename"];</i> does.

[lawnmowerman]

If you look at your SQL statement, there is no comma between "aolim = '$change_aolim'" and "email = '$change_email'"....

This should work for you:

$result = MYSQL_QUERY("UPDATE Users SET realname = '$change_realname', bnetwins =
'$change_bnetwins', bnetlosses = '$change_bnetlosses', bnetdisconnects =
'$change_bnetdisconnects', icq = '$change_icq', aolim = '$change_aolim', email =
'$change_email' WHERE ID = '$ID_array[$userid]'") or die(mysql_error());

Hope this helps!

-Rich

[[deleted]]

Insert aa copy of what james said here, and append:

Apart from your code being.. how do I put this nicely... "unreadable" 🙂

Don't nest so many functions, like "while(list()=mysql_fetch())"

Read the manual.

If MySQL complains about your statement, and tells you that there is a problem near "email" that should trigger you into looking at your statement near "email"
and you would have found a missing comma:

aolim = '$change_aolim' email =

should read

aolim = '$change_aolim', email =

A "duh" moment 🙂