elseif

Anon

I have an advanced search which has an if statement followed by b elseif and an else, all the elseifs work fine except the ones with multiple conditions like below,

elseif ($regionchoice == "All Regions" && $children == "Don\'t Mind" && $pool == "Don\'t Mind") {run query}

does any one know why this isn't working i have 3 elseifs similar to above, hope you can help, thanks Martin

[deleted]

Define "not working"
Did you print the $regionchoice etc variables to see if they contain what you think they contain?

Anon

yep, have tried that and it passes the variables, if that code is the first if statement then that piece of code works fine as does all the others, however when there elseif statements it just doesn't work

reagent

It sounds as if one of the previous elseifs is being evaluated to true when you don't expect it to be. Make sure that all your && and ||'s make logical sense and that they are grouped appropriately. Without more sample code, I can't be of much assistance.

Anon

This is the code i'm using, hope that helps, thanks, Martin

<?
$db = mysql_connect ("localhost", "root", "orange");
mysql_select_db ("billingtons", $db);

if ($regionchoice != "All Regions" && $children == "Don\'t Mind" && $pool == "Don\'t Mind") {
$query = "SELECT * FROM Property WHERE RegionID = $regionchoice AND sleepsMax >= '$partysize'";
printf ("first if");
}

elseif ($pool == "Don\'t Mind") {

$query = "SELECT * FROM Property WHERE RegionID = $regionchoice AND sleepsMax >= '$partysize' AND children = '$children'";
}

elseif ($children == "Don\'t Mind") {
$query = "SELECT * FROM Property WHERE RegionID = $regionchoice AND sleepsMax >= '$partysize' AND swimpool = '$pool'";
}

elseif ($regionchoice == "All Regions" && $pool == "Don\'t Mind" && $children != "Don\'t Mind") {

$query = "SELECT * FROM Property WHERE DestinationID = $region AND sleepsMax >= '$partysize' AND children = '$children'";
printf ("2nd if");

}

elseif ($regionchoice == "All Regions") {

$query = "SELECT * FROM Property WHERE DestinationID = '$region' AND sleepsMax >= '$partysize' AND children = '$children' AND swimpool = '$pool'";
printf ("allregions");

}

elseif ($regionchoice == "All Regions" && $children == "Don\'t Mind" && $pool != "Don\'t Mind") {

$query = "SELECT * FROM Property WHERE DestinationID = $region AND sleepsMax >= '$partysize' AND swimpool = '$pool'";
printf ("third if");

}

elseif ($regionchoice == "All Regions" && $children == "Don\'t Mind" && $pool == "Don\'t Mind") {

$query = "SELECT * FROM Property WHERE DestinationID = $region AND sleepsMax >= '$partysize'";
printf ("fourth if");

}

else {

$query = "SELECT * FROM Property WHERE RegionID = $regionchoice AND sleepsMax >= '$partysize' AND swimpool = '$pool' AND children = '$children'";
}
$res = mysql_query ($query, $db);
for ($i = 0; $i < mysql_num_rows ($res); $i++)
{
$row = mysql_fetch_row ($res);
printf ("<tr><td valign=\"top\" align=\"left\"><img src=\"../images/Property/$row[15]\" width=\"76\" height=\"76\"></td>\n");
printf ("\n<td valign=\"top\" align=\"left\">Property:%s \n", $row[2]);
printf ("\nDescription:%s \n", $row[13]);
printf ("\nResort:%s <td>\n", $row[4]);
printf ("\n<td valign=\"top\" align=\"left\">Type:%s \n", $row[10]);
printf ("\nSleeps Max:%s \n", $row[6]);
printf ("<a href=\"details.php?PropertyID=$row[0]\">Click here for more details</a></td></tr>\n");
?>

<?
}

if (mysql_num_rows ($res) == 0)
{
print ("<tr><td colspan=4>None</td></tr>\n");

}
mysql_free_result ($res);

mysql_close ($db);
?>

[deleted]

If elseif else evaluates on a first-match basis. It goes through all options from the top, and at the first match is stops checking the rest.

Look at the order in which you check for the values.

At one point you do this:

elseif ($regionchoice == "All Regions")

Once this evaluates to true, everything after it will not be checked,
so the line

elseif ($regionchoice == "All Regions" && $children == "Don\'t Mind" && $pool != "Don\'t Mind")

that comes directlry after the previous "regionchoice" line, cannot ever work, because the regionchoice will evaluate to true also.

reagent

Without knowing what those variables contain, i came up w/ the following solution. You are creating a separate query for each if, elseif, else condition, when you really want to create a base query and then add on to it based on certain conditions. Also, I wouldn't check for things like $regionchoice == "All Regions", because it leaves you more open to mistakes in your code (i.e. you add an extra space, don't capitalize a letter, etc..) Instead, I would use integer values to specify certain conditions, and even use define() to make it more readable.

i.e.
define("ALL_REGIONS", 1);
if ($regionchoice == ALL_REGIONS) {
....
}

Also, in a production system, i would shy away from using the "root" user, try setting up a new user w/ limited permissions.

Anyways, heres the code I came up with using your old method. Since I dont have the table structure and data you are using, I couldn't test, but you may need to modify to fix some bugs:

<?
$db = mysql_connect ("localhost", "root", "orange");
mysql_select_db ("billingtons", $db);

$query = "
SELECT *
FROM Property ";

if ($regionchoice == "All Regions") {
$query.= "WHERE RegionID = $regionchoice ";
}
else {
$query.= "WHERE DestinationID = $region ";
}

if ($pool != "Don\'t Mind") {
$query.= "AND swimpool = '$pool' ";
}

if ($children != "Don\'t Mind") {
$query.= "AND children = '$children' ";
}

$query.= "AND sleepsMax >= $partysize ";

$res = mysql_query ($query, $db);
for ($i = 0; $i < mysql_num_rows ($res); $i++)
{
$row = mysql_fetch_row ($res);
printf ("<tr><td valign=\"top\" align=\"left\"><img src=\"../images/Property/$row[15]\" width=\"76\" height=\"76\"></td>\n");
printf ("\n<td valign=\"top\" align=\"left\">Property:%s \n", $row[2]);
printf ("\nDescription:%s \n", $row[13]);
printf ("\nResort:%s <td>\n", $row[4]);
printf ("\n<td valign=\"top\" align=\"left\">Type:%s \n", $row[10]);
printf ("\nSleeps Max:%s \n", $row[6]);
printf ("<a href=\"details.php?PropertyID=$row[0]\">Click here for more details</a></td></tr>\n");
}

if (mysql_num_rows ($res) == 0)
{
print ("<tr><td colspan=4>None</td></tr>\n");

}
mysql_free_result ($res);

mysql_close ($db);
?>

hth

Anon

thanks for everyones help, i restuctured it, after everyones advice and it works fine now, thanks for everything, Martin