AHHA, I HATE THIS CODE

[rulian]

Will someone please tell me what the heck is wrong with this code?

if !($where="uploads"){
mysql_query("INSERT INTO uploads VALUES

(NULL,'$userid','$type','$title',curdate(),'$location1','$description','0','0','0','$location2','0','0')") OR die ("Could not write into database") kill();
}

ps. kill is suppose to be a function, will that work?

[smarlowe]

Rulian wrote:

Will someone please tell me what the heck is wrong with this code?

if !($where="uploads"){

The syntax here is wrong. = is an assignment operator in php, so $a=1 will make $a equal to 1. $a==1 will compare $a's value to 1.

In this line you are checking to see if you can put the value "uploads" into the variable $where. The assignment almost certainly will work, so it will be true, and the if statement will never execute.

You need to put the ! inside the parens for good style (I'm not even sure it will work with it outside the parentheses).

The proper way to write that would then be:

if (!$where=="uploads"){

or

if ($where!="uploads"){

[polson]

What Scott said and regarding your other question about kill() with die(), try :

or die( kill() );

Which is in similar fashion to the popular :

or die( mysql_error() );

Die() dies, you are calling kill() after the death, which will not work. One can enter text too :

or die( kill() . ' : unable to connect' );