if you can't answer, say why

icd_lx

OK, this is my 4th time asking for help, with this most recent code. I can't figure out why this script won't output any threads. I've corrected what others said I should, but I'm still stuck.

Is there a cleaner way to do this? Is the problem obvious?

//Count the number of threads and pages
$countrows = mysql_query("SELECT * FROM topics WHERE forum='$forum'", $connect);
$numtopics = mysql_num_rows($countrows);
$numpages = intval($numtopics/20);
if($numpages < 1)
{
$numpages = 1;
}
$numlast = $numtopics % 20;
if($numlast != 0)
{
$numpages++;
}

//Which topics to display
if($page != 1 && $numtopics > 20)
{
$last = (20 $page) - 20;
$first = 20 $page;
}
if($page == 1 && $numtopics > 20)
{
$last = 1;
$first = 20 - $numlast;
}
if(numtopics <=20)
{
$last = 1;
$first = $numtopics;
}

?>
<CENTER>
<TABLE>
<?
//List the topics
if($addpost == "no" || !$addpost)
{
for($count=$first; count>=$last; $count--)
{
$dummy = mysql_query("SELECT FROM topics WHERE number='$count'", $connect);
$check = mysql_fetch_array($dummy);
if($forum == $check[forum])
{
$thread[$count] = $check;
}
if($forum != $check[forum])
{
$count++;
}
}
for($count=20; count>=$last; $count--)
{
echo "<TR>";
$current++;
$whatever2=mysql_query("SELECT FROM posts WHERE thread='$thread[$count][title]'", $connect);
$numposts=mysql_num_rows($whatever2);
echo "<TD WIDTH='30%'><A HREF='http://forum.levx.net/postview.php?thread=".$thread[$count][title]."&page=1&addpost=no&forum=".$forum.">".$thread[$count][title]."</A></TD><TD WIDTH='15%'>".$thread[$count][user]."</TD><TD WIDTH='5%'>".$numposts."</TD><TD WIDTH='50%'>".dconvert($thread[$count][date])."</TD></TR>";
if($count == 20)
{
echo "</TABLE>";
}
}

jalexf

There are too many things going on for me to disassemble why that may not be working. Have you isolated it down to which query is not producing results?

What part of the code is not working?

Can I see it live?

I'm not a brilliant programmer (UI designer infact) but I'm willing to take a stab at it if you reduce it to the non-functioning parts.

Do all of your queries produce result sets in a SQL shell? Can you put hardcoded dummy info into the query results and have the PHP code split the pages properly?

ignore me if this is too basic for you...

also just a note, but I believe that count rows will be slower since you are selecting * from the table.. If you have varchars or blobs in there, they have to be loaded when all you really want to count is the ID#'s. So a SELECT COUNT(forumid) would probably be more efficient. (yea like I should give lessons on db efficiency hah)

Anon

Why don't you put echo's in your code so you can figure out where your code is breaking down. That is a lot of code to ask people to help you with, you should atleast try to narrow the problem down to a few lines of code. You may even figure out your problem in the process.

icd_lx

Sorry about that,... its just that i dont know which part is non-functioning. If I did, my problems would be solved lightning-fast.

I have a table of threads from multiple forums. The script has to count the number of threads from the current forum and then calculate the starting and ending 2 IDs with which it will use in the thread-displaying loop. The oldest threads have lower IDs and the newer ones have higher IDs, so the loop goes downwards.

Everything is to be sorted in pages of 20 threads, with page #1 (right now) being the last page.

And you can find this at forum.levx.net(expect to find stupid posts like "i farted" (hehe), been testing) I know i can MAKE threads)

ziong

is this?
for($count=20; count>=$last; $count--)
=>
for($count=20; $count>=$last; $count--)