Matching within while's

[brainiac]

I can't get the code below to match more than the very first run, what's wrong with it?
$genres are the number of genres in a database.
$query_genre are a query for all genres in the genre table og a database.
$current_genre are the genres that is pulled out for one specific movie.

Then I want to see if the genres set for the movie matches the genres from the database, if they do it will be selected.
Take a look at the code and I think you now where I'm going with it.

<?php
$query_genre = mysql_query("SELECT * FROM genre ORDER BY genre_id ASC");
$current_genre = mysql_query("SELECT genre_id FROM genre_movie WHERE movie_id=$movie_id");
if (mysql_num_rows($current_genre) == 0) {
unset($current_genre);
}
$genres = mysql_num_rows($query_genre);

echo "<select class=\"formfield\" name=\"genre[]\" multiple size=\"$genres\">";
while ($g_row = mysql_fetch_array($query_genre)) {
$genre_id = $g_row["genre_id"];
$genre = $g_row["genre"];
if (isset($current_genre)) {
while ($cg_row = mysql_fetch_array($current_genre)) {
$cgenre_id = $cg_row["genre_id"];
if ($cgenre_id == $genre_id) {
$selected = " selected";
}
elseif (($genreid != $genre_id) && (isset($selected))) {
unset ($selected);
}
}
}
else {
if (isset($selected)) {
unset($selected);
}
}
}
echo "<option value=\"$genre_id\"$selected>$genre";
echo "</select>";
?>

Here is a dump of both my genre table and my genre_movie table.

CREATE TABLE genre (
genre_id int(5) NOT NULL auto_increment,
genre text NOT NULL,
PRIMARY KEY (genre_id),
UNIQUE genre_id (genre_id)
);

CREATE TABLE genre_movie (
genre_id int(5) DEFAULT '0' NOT NULL,
movie_id int(5) DEFAULT '0' NOT NULL,
PRIMARY KEY (genre_id, movie_id)
);

[Anon]

Hi,

You never close the option TAG

echo "<option value=\"$genre_id\"$selected>$genre";

should be

echo "<option value=\"$genre_id\"$selected>$genre</option>";

If I understand what you want you should place this line into the while condition

echo "<option value=\"$genre_id\"$selected>$genre</option>";

If you don't put this line into the while condition the echo of the <option> will be executed only one time.

So you code would be:

<?php
$query_genre = mysql_query("SELECT * FROM genre ORDER BY genre_id ASC");
$current_genre = mysql_query("SELECT genre_id FROM genre_movie WHERE movie_id=$movie_id");
if (mysql_num_rows($current_genre) == 0) {
unset($current_genre);
}
$genres = mysql_num_rows($query_genre);

echo "<select class=\"formfield\" name=\"genre[]\" multiple size=\"$genres\">";
while ($g_row = mysql_fetch_array($query_genre)) {
$genre_id = $g_row["genre_id"];
$genre = $g_row["genre"];
if (isset($current_genre)) {
while ($cg_row = mysql_fetch_array($current_genre)) {
$cgenre_id = $cg_row["genre_id"];
if ($cgenre_id == $genre_id) {
$selected = " selected";
}
elseif (($genreid != $genre_id) && (isset($selected))) {
unset ($selected);
}
}
}
else {
if (isset($selected)) {
unset($selected);
}
}
echo "<option value=\"$genre_id\"$selected>$genre</option>";
}
echo "</select>";
?>

Hope this helps. Tell me if It works.

[brainiac]

Here is the code again, -with- comments, if not noticed in the comment, my code is as shown.
To give a resumé:

The problem is that it apparently only matches in the first loop in the while, f.eks.:
I have a movie with genre_id's 1,2 and 7 set to it, the script will match the one and then not unset $selected again,
where if the movie had genre_id's 2,3 and 6 set to it, (everything not starting with the genre_id 1), will not match at all.

<?php
if (!$movie_id) { // Checking if a movie was chosen
echo "No movie selected";
exit;
}
$query_genre = mysql_query("SELECT * FROM genre ORDER BY genre_id ASC"); // Query the database for ALL genres
$current_genre = mysql_query("SELECT genre_id FROM genre_movie WHERE movie_id=$movie_id"); // Query the selected movie for genres
if (mysql_num_rows($current_genre) == 0) { // Checking that the movie has genres set to it, if not then unset $current_genre
unset($current_genre);
}
echo "<select class=\"formfield\" name=\"genre[]\" multiple size=\"$genres\">";
while ($g_row = mysql_fetch_array($query_genre)) {
$genre_id = $g_row["genre_id"];
$genre = $g_row["genre"];
if (basename($PHP_SELF) == "/movie_edit.php") { // Only match genres if the current page are movie_edit.php, (the form are being used in 2 documents, for some reason it doesn't work though, so is is commented out in my own code)
if (isset($current_genre)) { // Only match genres if the movie have genres set to it.
while ($cg_row = mysql_fetch_array($current_genre)) {
$cgenre_id = $cg_row["genre_id"];
if ($cgenre_id == $genre_id) { // Checking the genres set in the movie with the currently selected genre in the while loop, if a match then set $selected
$selected = " selected";
}
elseif (($genreid != $genre_id) && (isset($selected))) { // If They do not match and $selected is set, then unset $selected
unset ($selected);
}
}
}
else { // if current page isn't movie_edit.php then unset $selected if $selected id set, (commented out in own code because it for some reason won't work)
if (isset($selected)) {
unset($selected);
}
}
}
echo "<option value=\"$genre_id\"$selected>$genre"; //echo the currently selected genre in the while loop out, (<option> do not requiere an end tag, it is allthough recommended, I know 😉
}
echo "</select>";
?>

[Anon]

???

This code still doesn't work?

Tell me about the output of this code.

[brainiac]

I found one error in my code, I realised that the $selected was unset within the second while loop, now it should only unset $selected at the start of the loop.
But it still doesn't work, now it returns true -ONLY- if the movie has $genre_id=1, even though the movie also has $genre_id=2 only 1 is set as selected.

Here is the revised code.

<?php
if (!$movie_id) { // Checking if a movie was chosen
echo "No movie selected";
exit;
}
$query_genre = mysql_query("SELECT * FROM genre ORDER BY genre_id ASC"); // Query the database for ALL genres
$current_genre = mysql_query("SELECT genre_id FROM genre_movie WHERE movie_id=$movie_id"); // Query the selected movie for genres
if (mysql_num_rows($current_genre) == 0) { // Checking that the movie has genres set to it, if not then unset $current_genre
unset($current_genre);
}
echo "<select class=\"formfield\" name=\"genre[]\" multiple size=\"$genres\">";
while ($g_row = mysql_fetch_array($query_genre)) {
$genre_id = $g_row["genre_id"];
$genre = $g_row["genre"];
if (basename($PHP_SELF) == "/movie_edit.php") { // Only match genres if the current page are movie_edit.php, (the form are being used in 2 documents, for some reason it doesn't work though, so is is commented out in my own code)
if (isset($selected)) { // Unsetting $selected for next loop
unset($selected);
}
if (isset($current_genre)) { // Only match if any genres found for the movie
while ($cg_row = mysql_fetch_array($current_genre)) {
$cgenre_id = $cg_row["genre_id"];
if ($cgenre_id == $genre_id) { // Matching the genres, if a match then set $selected
$selected = " selected";
}
}
}
}
echo "<option value=\"$genre_id\"$selected>$genre</option>"; //echo the currently selected genre in the while loop out, (<option> do not requiere an end tag, it is allthough recommended, I know 😉
}
echo "</select>";
?>