URGENT: Can't see picture

Anon

I'm having a ton of trouble trying to get pictures to display. At first, I thought I had the problem fixed but that's because the pictures reside on my machine. So, I tried absolute paths and that hasn't solved the problem either. I'm hoping someone will have a suggestion because i'm getting pretty desperate.

Thanks,
Mike

<?PHP
session_start();
include("dblib.inc");
?>
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">

<head>
<title>Uploading your potrait</title>
<Link href="arial.css" rel=stylesheet title=arial type=text/css>

<body>
<img src="pics/logo.gif">
 
<H3>Portrait Picture</h3>
<?PHP
//defines location
$filedir = "../userpics";

//check for jpeg image type
if($fupload_type =="image/pjpeg")
{
//copies picture to new directory and renames to username
if(copy($fupload,"$filedir/$CUserName.jpg"))
{
print ("Hey Goodlooking! Your picture has been uploaded correctly ");
print "<table border=1>
<TR>
<TD height=\"300\" width=\"300\" align=\"center\">";
print ("<img src=\"$filedir/$CUserName.jpg\">");
print"</td>
</tr></table>";
print " <a href=\"memberprofile.php?$PHPSESSID\">Home</a>";
print " <a href=\"fupload.php\">Upload again</a> ";
//adds 'yes' to database so user can search only profiles with pictures.
$query="UPDATE clients SET CPicture='yes' WHERE CUserName='$CUserName'";
//FAILED PROCESS
if(!mysql_query($query))
{
print "A process has failed during the update. Please report this incident to the Web Master <a href=\"mailto:mjyuen@hotmail.com\">mjyuen@hotmail.com</a> ";
print " <a href=\"memberprofile.php?$PHPSESSID\">Home</a>";
return false;
}
return true;
}
die ("Error in uploading. Please try again");

else
{
//PRINTS IF PICTURE IS ANYTHING BUT JPEG FORMAT
print "In order to show off your qualities to the fullest extent. LDSAlberta.com currently only acceptes pictures in JPEG format which have the highest color quality and in turn show you off the best!";
print " <a href=\"memberprofile.php?$PHPSESSID\">Home</a>";
print " <a href=\"fupload.php\">Upload again</a> ";
}
unlink($fupload);
mysql_close();
?>
</body>

Anon

I know the feeling 🙂

I assume you have made a special DIR for storing the uploaded pics... Do you get an error uploading? have you CHMOD 777'd the upload folder?

Apart from that I can't think of anything. here is some uploading code i wrote for something, it works fine, maybe you can get some clues from it:

if(!$description OR !$adder OR $remotefile=="none"){
echo "Sorry, you missed a field on the form. All fields are required.";
}
else{
// Get the file extension. Only .rep files are allowed.
$filebits=explode(".", $remotefile_name);
if($filebits[1]=="rep"){
// Generate a unique filename...
$localfile="C:\inetpub\wwwroot\newsc\replays\$REMOTE_HOST".time().".rep";

  //Upload the file
  copy($remotefile, $localfile); 

  // cut off the path info to make a relative file path
  $localfile=str_replace("C:\\inetpub\\wwwroot\\newsc\\replays\\","",$localfile); 

  // Store the path to the file in the DB
  $sql="INSERT INTO tgsc_replays VALUES ('', '$adder',".time().",'$description','$localfile','')";
  mysql_query($sql); 

  // Display success/error message
  if(mysql_affected_rows($LINK_ID)) 
    echo "Thanks, your replay was added!"; 
  else 
    echo "Sorry, there was an error, please try again later.";
}
// tell them to get lost if the extension is wrong.
else message("Invalid file type!<br>The file must be a Starcraft game replay file.");

}
}

Anon

Hi Arta. Can you show me one of your <img src> tags so I can see how the above code ties in with the picture?

Thanks for your help.
Mike

sucro

sure.
echo"<img src=\"$image1\">";

$image1 is the relatve filepath extracted from the database.

the best way to do this is to store only the filename in the database- with no path at all. ie "mypic.jpg"

then construct your page thus:

echo"<img src=\"/path-to-images/$ImageFilename\">";

If you are running an NT server remember to use escaped slashes if you are using a full filepath, ie:

c:\inetpub\wwwroot\path-to-images\$ImageFilename

mail me if u want. (arta@the-group.org)