if else problem

Anon

<?
if($id){
mysql_connect("localhost", "temp", "password")
or DIE("Unable to connect to database");
@mysql_select_db("test") or die("Unable to select database");
$result = mysql_query("select * from links where catid='$id'");
$row = mysql_fetch_array($result);
?>

<frameset rows="12%,1*">
<frame name=top src=top.php scrolling=no noresize>
<frame name=bottom src=<? PRINT "$url"; ?>>
<noframes>
<body>
<div class=Section1>
<p>This page uses frames, but your browser doesn't support them. </p>
</div>
</body>
</noframes>
</frameset>

<?
}
else { ?>

<HEAD>
<TITLE>Oh, we hit a problem!</TITLE>
</HEAD>
<BODY>
<br>Sorry, we have a problem!<br>

<? } ?>
</BODY>

I used link.php?id=0 although the query seems to work , when i click the link it passes and shows the "else" bit???

Thanks in advance,
Paul

Anon

Hmm, have you tried with link.php?id=2 or something else than 0 and 1.

I think it's because, when you set $id to 0 it's like setting it to false...
and when asking if($id) it will return false...

If you set $id to 1 it's like setting it to true...

Try using if(isset($id)) to check whether $id is set or not.

Kenneth

Anon

Excellent thanks, getting somewhere!

With regrads to this code:

$result = mysql_query("select * from links where linkid='$linkid'");
$row = mysql_fetch_array($result);

I don't seem to be returning any records now and was wondering if this is right? I have checked that all the names are right for the array, have i missed a bit?

Thanks again,
Paul

Anon

Here's a piece of code I always use to debug an array:

$row = mysql_fetch_row($result);

print_r($row);

If you get anything back from the query, you'll know exactly what you get. You can do the same with mysql_fetch_array().

Until I found print_r by accident in the manual I always had trouble making sure my querrys came back as I expected them to. Much easier using print_r, as you don't need foreach or each().

Hope that helps.

Oh and btw, you might try using the opening tag "<?php" rather than "<?", if for no other reason than it ensures maximum portability in your code. It is also PEAR compliant, if that matters to you 🙂

Anon

YES!!! you deserve a pay rise 🙂

I also forgot <? PRINT $row["url"] ?>! Thanks to Danny Tuppeny for that tip!

It all makes sense now!

Thanks for everything,
Paul

Until Next time 🙂