Adding users to a database

[bonehooray]

Hello.

I want to add users to a database. To do that, I will need to check the database and make sure no other is using the username they are trying to add. How can I do that?

Regards,

thebone

[jc94062]

Easy :-)

Step 1 - Connect to db
Step 2 - Select username or whatever from table
Step 3 - Set variable for this username
Step 4 - Check if variable is the same as the name they entered
Step 5 - Give error or add to db.

<?php
//connect to db
$db = mysql_pconnect("localhost", "dbusername", "password");
mysql_select_db("dbname",$db);

//get username from table
$checkuser=mysql_query("SELECT username FROM tablename",$db);
while($detail=mysql_fetch_array($checkuser)) {
$userfromtable = $detail["username"];

//if username is the same, error
if ($userfromtable == $username) {echo "Sorry, that username is taken, please choose another"; exit; }
//is username is different, insert
elseif ($userfromtable != $username) {INSERT into ... }

//this ends the while loop
}

?>

It may be a little confusing cause I user username, user, and things so much, if you need clarification or anything yell.
I'm also assuming your fine with the form stuff.

[bonehooray]

I think that will do the trick...I'll try implementing it tomorrow or something.

[Anon]

I think it's the inserting part thats not very cooperative this time. Here's my code:

<?php

if ($submit) {
if (!$username || !$password || !$email) {
$error = '<p class=text>Fill out all the fields</p>';

	} else {
	$checkuser=mysql_query("SELECT username FROM members",$db);
	while($detail=mysql_fetch_array($checkuser)) { 
	$userfromtable = $detail["username"]; 
	if ($userfromtable == $username) {echo "Sorry, that username is taken, please choose another"; 

	exit; 

	}


	elseif ($userfromtable != $username) {INSERT INTO members (username,password,email) VALUES ('$username','$password','$email,";


	echo "<p class=text>Thanks. Registration complete.</p>";

}

}

if (!$submit || $error) {

echo $error;

?>

You can view the script at
http://zkole.com/registrer.php
I get a parse error at l26.

[laurabrandt]

Instead of using mysql_fetch_array, you can also use this method which is simpler:

<?php
//connect to db
$db = mysql_pconnect("localhost", "dbusername", "password");
mysql_select_db("dbname",$db);

//get username from table
$checkuser=mysql_query("SELECT username FROM tablename WHERE username='$userfromtable'",$db);

//if username is the same, error
if (mysql_num_rows($verifyusername) == 0) {echo "Sorry, that username is taken, please choose another"; exit; }
//is username is different, insert
else {INSERT into ... }

//this ends the while loop
}
?>

Hope this helps.

Laura Brandt

--
Aletia Hosting - Full-Featured, Superfast Web Hosting
200MB + 10GB Transfer at $9.95/mth
http://AletiaHosting.com

[laurabrandt]

I think you have an extra , on the following line

('$username','$password','$email,";

also you have no closing bracket.

A clearer way to do an insert will be something like this:

<?php
$checkuser= "INSERT INTO members SET " .
"username='$username', " .
"password='$password', " .
"email='$email' ";

mysql_query ($checkuser);
?>

Hope this helps.

Laura Brandt

Aletia Hosting - Full-Featured, Superfast Web Hosting
200MB + 10GB Transfer at $9.95/mth
http://AletiaHosting.com

[Anon]

his is my script as of now, I'm getting an error message on line 18 (it's the $checkuser=mysql_... line).

By $userfromtable, you mean the inputted username from the registration form, right?
And where does the $verifyusername pop out from?

<?php

if ($submit) {
if (!$username || !$password || !$email) {
$error = '<p class=text>Du kan i det minste fylle ut alle feltene</p>';

} else {

	$checkuser=mysql_query("SELECT username FROM members WHERE username='$username'",$db);
	if (mysql_num_rows($verifyusername) == 0 {
		$error = '<p class=text>Brukernavnet er dessverre opptatt</p>'; exit;
	} else {
		INSERT into {INSERT INTO members (username,password,email) VALUES ('$username','$password','$email';
		echo "<p class=text>Takker så meget. En epost har blitt sendt til din adresse som forteller deg hvordan du tar i bruk din nye Zkole.com-konto</p>";
	}			

}
if (!$submit || $error) {
echo $error;
?>

Thanks for the help and regards,

Stig Eidissen

[jc94062]

Well, I'll look over it more later, but I have to go in a minute to try what I think is the recommended way...

if ((!$username) || (!$password) || (!$email)) {

Also, the other way of inserting, it should work okay, there are several ways, I just used the one I'm used to, depends on what your style is I guess, I've only got the time to get my pages working, it may not fastest code way, but it does work.

if (mysql_num_rows($verifyusername) == 0)

is bascially that is the number of rows in the db with the $verifyusername in them is 0, ie none, its fine, the same as my

if ($username != $verifyusername)

[laurabrandt]

If you are using $checkuser then the checking code should be

if (mysql_num_rows($checkuser) == 0) { do something}

else { do something }

Laura Brandt

--
Aletia Hosting - Full-Featured, Superfast Web Hosting
PHP, MySQL, Perl, Multiple domain support and more.
200MB + 10GB Transfer at $9.95/mth
http://AletiaHosting.com

[jc94062]

elseif ($userfromtable != $username) {INSERT INTO members (username,password,email) VALUES ('$username','$password','$email,";

hmmm, Laura pointed out the extra comma and lack of bracket, ending the quote with a single as opposed to double quote would be good as well.

elseif ($userfromtable != $username) {INSERT INTO members (username,password,email) VALUES ('$username','$password','$email');

(btw, if you want a faster reply use [e-mail].)