PHP Random Image Script..

Anon

Ok, I'm a php newbie and found this script somewhere.. can someone help me fix it please? Thanks!

<?php
$banner_folder_sys = "/www/fury/html/test/header";
$banner_folder_url = "http://fury.qgl.org/test/header";

$mydir = dir("$banner_folder_sys");
$amount = 0;
while($entry = readdir($mydir))
{
$tmp = split(".", $entry, 2);
if ($tmp[1] == "jpg" || $tmp[1] == "JPG")
{
$img[] = $entry;
$amount++;
}
if ($tmp[1] == "gif" || $tmp[1] == "GIF")
{
$img[] = $entry;
$amount++;
}
}

mt_srand((double)microtime()*1000000);
$random_image = mt_rand(0,$amount);
echo "<img src=$banner_folder_url/$img[$random_image] width=750 height=150>";
?>

Now the problem:
Warning: Supplied argument is not a valid Directory resource in /www/fury/html/test/rimage.php on line 7

Warning: mt_rand(): Invalid range: 0..0 in /www/fury/html/test/rimage.php on line 23

Please Help!!
Thanks!

brandonschnell

are there any .jpg or .gif files in /www/fury/html/test/header/ ? put a couple of images there and make sure the folder exists.

Anon

Yes, there are 3 images in there (all the same but with different names).

brandonschnell

yep, the script is flawed. try this:

<?php
$banner_folder_sys = "/www/fury/html/test/header/";
$banner_folder_url = "http://fury.qgl.org/test/header";

$mydir = opendir("$banner_folder_sys");
$amount = 0;
#create new array
$img = array();

while(false !== ($entry = readdir($mydir)))
{
$tmp = split(".", $entry, 2);
if ($tmp[1] == "jpg" || $tmp[1] == "JPG")
{
$img[] = $entry;
$amount++;
}
if ($tmp[1] == "gif" || $tmp[1] == "GIF")
{
$img[] = $entry;
$amount++;
}
}

#clean up
closedir($mydir);

#seed rand
mt_srand((double)microtime()*1000000);

$random_image = mt_rand(0,$amount);
echo "<img src=$banner_folder_url/$img[$random_image] width=750 height=150>";
?>

Anon

Thank you sooooo much! 🙂

Anon

That code works but I notice that if you continue to refresh the page, at least one in every ten times the image will appear as missing. Any idea on how to fix that from happening?
Thanks.

Anon

I didn't have this problem, everything worked fine for me. Could it be your server or ISP? I have the trouble sometimes on random servers where I don't get the image so i have to right clik => show image.

Otherwise the only thing i can suggest is you have other files in the directory?

Anon

The problem with the script is that the $amount value goes from 1 through to n, while the $img array goes from 0 through to n (where n is the number of images you have in the directory). If you have 4 images in the directory for example, you have img[0], img[1], img[2] and img[3], but mt_rand will return a number between (and including) 0 and 4 (ie: one of five values).

The fix is to change the line that reads:

$random_image = mt_rand(0,$amount);

$random_image = mt_rand(0,$amount-1);

(note: there are a number of ways to acheive this result).

Anon

Isn\'t this easyer ?

<?php
include \"include.inc\";
?>

<img src=\"<?php echo getImage(\"image.gif\", \"image.gif\")?>\" border=\"0\">

include.inc :

<?php

srand((double)microtime()*1000000);

function getImage($img1, $img2)
{
	$randval = rand(0, 1);
	if($randval == 0)
		return $img1;
	else
		return $img2;
}

Anon

This will work better

<?
srand((double)microtime()*1000000);

function getImage($img1, $img2)
{
$randval = rand(0, 1);
if($randval == 0)
return $img1;
else
return $img2;
}

$img1="iceage.jpg";
$img2="peterpan.jpg";

<img src="
<?php echo getImage($img1, $img2);?>
" border="0" width="328" height"242">