Function that returns a mysql query

Anon

Can anyone please explain why this doesnt work. It throws a "Supplied argument is not a valid MySQL result resource in library.php on line 1" error...

// START

FUNCTION DBcommand($statement)
{
$dbname = 'sample_db';
$hostname = 'localhost';
$username = 'test';
$password = 'test';
$id_link = @mysql_connect($hostname, $username, $password);
$result = mysql_db_query($dbname, $dbcom, $id_link);
return $result;
}

$result=DBcommand("select * FROM mytable");
$row = mysql_fetch_array($result);
print $row['field1'];

// END

Anon

Sorry... stupid mistake, function call should of looked like this:

"FUNCTION DBcommand($dbcom)"

But while you're at it... is this method the best way of doing generic mySQL execs??

Anon

This topic seems a bit dated but I will reply none the less.
If you connect outside of the query function, where you only connect the one time, what is the disadvantage of using mySQL over PEAR. (Besides not having the easy migration capabilites)
For example:

// In your page
$dbname = 'sample_db';
$hostname = 'localhost';
$username = 'test';
$password = 'test';
$id_link = @mysql_connect($hostname,
$username, $password);

DBCommand('select * from foo');
// do whatever with result and disconnect.

Is there a problem with this methodology?