sql statements on the fly (sorta)

Anon

ok, i am probably going about it the wrong way but i made an admin script for a newsboard where i can delete/modify messages. My script isnt working tho, anyone that can help me with it?
heres the code

<?
$conn = mysql_connect("localhost", "", "")
or die ("Couldnt connect to server");

$select_db = mysql_select_db($dbname, $conn)
or die ("Failed to select database");

$query = mysql_query("DELETE * FROM $dbname WHERE image ='$image' AND textstuff = '$text' AND datetoday = '$date'");

if($query) {
echo "success";
} else {
echo "failed";
}
?>

the script is giving me the custom error message "failed" from near the end of the script, and isnt deleting the record from the database. Any suggestions?

brandonschnell

hopefully you should have a column with a unique id number to identify the row.

then your query will be:
$query = mysql_query("DELETE * FROM $dbname WHERE id = '$id'");

and on your admin script for each message to delete go to the next page like so:
<A HREF="http://yoursite.com/delete.php?id=5">Delete Me!</A>

when the user clicks on the "Delete Me!" the script passes to the next page the id of the message to delete.

veron

Your problem is pretty simple, and I think everyone has done it before.. Remove the * from your query, DELETE does not need/does not like it.

$query = mysql_query("DELETE * FROM $dbname WHERE image ='$image' AND textstuff = '$text' AND datetoday = '$date'");

Anon

<?
$conn = mysql_connect("localhost", "", "")
or die ("Couldnt connect to server");

$select_db = mysql_select_db($dbname, $conn)
or die ("Failed to select database");

$query = mysql_query("DELETE FROM $dbname WHERE image ='$image' AND textstuff = '$text' AND datetoday = '$date'");

if($query=="1") {
echo "success";
} else {
echo "failed";
}
?>

brandonschnell

argh, can't believe i missed that. i've got to stop copying and pasting code and start actually reading it =)

and binky, find a better way to uniquely identify the columns to delete.