File uploading problem

Anon

I'm experiencing a file upload problem. It isn't the code(I compared it with tousands and tousands codes around the internet) neither configuration(yes, file_upload is On), here is the problem:

i do the <form enctype=mu.... etc.
<input type=file name=nfile>

when i receive data, the file is uploaded, BUT it's stored on $nfile! I don't know what's the problem, and i've been consulting apache documentation, php documentation and they couldn't solve my problem.

that array $HTTP_POST_FILES also doesn't work.

any help will be welcome

fandelem

post your script, please

akozlov

It's simply.
First, in HTML make form:
<form action=script.php method="post" enctype="multipart/form-data">
<input type="file" name="userfile">   <input type="submit" value="[ Ok ]">
</form>

"input" tag MUST have name "userfile"! (see php docs!)

and in script.php after posting you have next variables:
$userfile - The temporary filename in which the uploaded file was stored on the server machine.
$userfile_name - The original name or path of the file on the sender's system.
$userfile_size - The size of the uploaded file in bytes.
$userfile_type - The mime type of the file if the browser provided this information.
Hope i'm help you.

fandelem

right, i meant post your script.. not the html part, however it does look like you are doing the html part right (i am just trying to narrow down where the problem could be). go ahead and post your upload script.

akozlov

Ok, i write sample bellow, it's copy uploaded file to new location, full check error, and print some information about file:

<?
if( !$userfile ) {
if ( $userfile_name ) {
die("<h1>Somthing Wrong</h1>\n");
} else {
die("<h3>Please select file and click [Ok]</h3>\n");
}
}
echo "File size: ".$userfile_size."<br>\nMime file type: ".$userfile_type."<br>\n";
// copy file to new location
if( !copy($userfile,"/usr/local/web/uploads/newuploadfile") ) {
die("<h3>Failed to copy file, may be access denied in new location</h3>\n");
}
// remove tempory file, don't forget to make it always
unlink($userfile);
echo "<h3>Fanx for you uploads</h3>";
?>

fandelem

i don't really know what to tell ya.. i don't understand when you say it is being copied to "$nfile" do you mean the actual filename is called $nfile or the contents of $nfile? if it is the latter, then isn't that correct?

anyways, here is my uploading script i use for an image hosting website i just wrote:

function upload_file($new_dir, $userfile, $userfile_name, $overwrite, $home, $current_user_id) {
global $DB_CONF, $date;
// incoming:
// $new_dir (the directory path, such as /home/kdavis/www
// $userfile (this is php's file, and wll look like "php31.php"
// $userfile_name (this is the actual filename the user is trying to upload)
// $overwrite (this will be 0 if the user doesn't want to overwrite, 1 if so)
// $home is for redirecting; you may remove it, along with the redirect() function
// $current_user_id is from session variables (disregard anything with it)

     $message = ""; // this will contain the "overwrite message" if user has selected it.
     $userfile_name = strtolower($userfile_name);
     chdir($new_dir); // this is very important
     if ( file_exists($userfile_name) && ($overwrite != '1') ) {
     // this means file exists, but user hasn't selected to overwrite it.
          echo "\n\n
          <body>
          <h2>Error: <font color=red><i>$userfile_name</i></font> already exists.</h2>
          Please go back and click on the \"overwrite\" checkbox if you wish to really overwrite this file.
          </body>

          ";
          exit;
     }
     else if ( file_exists($userfile_name) && ($overwrite == "1") ) {
     // checking to make sure index.html isn't being overwritten
        if ($userfile_name == "index.html") {
             echo "\n\n
             <body>
             <h2>Error: <font color=red>You CANNOT overwrite <i>index.html</i> because it already exists.</font></h2>
             <body>

             ";
             redirect('3','admin=edit_content', $home);
             exit;
        }
     // let's add a message variable for later
     $message = "<body><p><font size=+1>$userfile_name</font> has been <b>successfully</b> overwritten.</body>";
  } // end ifblock where overwriting occurs
  else if ( $userfile == "none" ) {
     // this means a user hasn't specified a file, "none" is the default NULL for filenames
             echo "\n\n
             <body>
             <h2>Error: <font color=red>You MUST specify a file..</font> redirecting.</h2>
             <body>

             ";
             redirect('3','admin=edit_content', $home);
             exit;
     } // end userfile==none

     // okay, this is our uploading a new file ifblock (if we make it here, everything is in order)
     if ( ($message != "") || (file_exists($userfile)) ) {
     // i use file_exists() to make sure the tempfile has been uploaded.
           $fp = fopen($userfile_name, "w"); // create USER SPECIFIED file
           copy("$userfile", "$userfile_name"); // copy php's temp file to USER SPECIFIED filename.
           fclose ($fp);
           unlink("$userfile"); //and delete the temp php file
           chmod($userfile_name, 0777); // proper user rights
           if ( (filesize($userfile_name)) > '1' ) {
                 echo "File uploaded.. <font size=red>successfully</font>.";
           }
           $file_stats = "\n\n
           <body>
           <hr>
           <h2>File Stats:</h2>
           <TABLE border=10 cellpadding=10>
           <TR>
            <TD>FILE:</TD>
            <TD>$userfile_name</TD>
           </TR>
             <TD>FILE SIZE:</TD>
             <TD>" .filesize($userfile_name). " bytes</TD>
           ";

                 if ( $message != "" ) { // this will display if they have selected "overwrite"
                    echo "<TR><TD>$message</td></tr>";
                 }

           echo "
           </TR>
           </TABLE>
           ";
           echo "$file_stats";

     // let's create a link from our newly uploaded file
     $link = makelink($new_dir, $userfile_name, $current_user_id);
     $link = addslashes($link);
     // now we'll grab the email for the user
     $email = getemail($current_user_id);
     $msg = "Hello,\n\nYour cut and paste codes for the file $userfile_name:\n\n".stripslashes($link)."\n\nThis is an automated message; please do not reply.  If you feel that you have received this transmission in error, disregard it.";
     // and send the email with their cut and paste codes
     sendemail($email, $msg);

     // let's add this link to the database
     fileinsert_database($userfile_name, $current_user_id, $link);

     // and now we'll display the codes in the current browser for convenience
     echo "<table width=\"100%\"><tr><td NOWRAP>
     <br>Your cut and paste codes for this file:<br><br> <b>".htmlspecialchars(stripslashes($link))."</b><br> (they have been mailed to you as well).<br><br><a href=\"$home?admin=edit_content\">return to file menu</a>
     </td>
     </tr>
     </table></body>";


     } // end else ifblock

} // end upload

hope it can help,

~kyle

akozlov

Ok, but i can't understand, where is problem? )
My answer and sample for Roberto Freire.
But you write this so long script for me.
Any problem with you script? Where? Tell me, and may be i can help )))

Anon

First of all, thanks everyone for answering me, this forum is great 🙂...

The problem isn't with the code:

a.html, for example:
<form enctype=multiparm/form-data method=post action=a.php>
send file: <input type=file name=file>
<input type=submit></form>

a.php:
<? echo $file_name; ?>

The problem:
I do not receive $file_<etc.>, what i receive is a single variable($file) with the file type(Content-Type), file name(name="...") and the file content in it!

$file goes like this:
Content-type: text/plain;
name="filename.ext"

content
content

--> My question: is this a configuration problem or what? Thanks in advance for any help, you guys are great.