php function to add news to a site...

Anon

I have created a SIMPLE function to update a table in mySQL, but for some reason it won't work.

function addMainPage($title, $content) {
$db = mysql_connect("localhost", "root", "") or die("Could not connect");
$query = "INSERT INTO mainpage (title, content) VALUES ('$title', '$content');";
mysql_db_query("$db", "$query") or die("Couldn't add contents foo!");
mysql_close($db);
}

The database name is intranet, the table name is mainpage (all lower case). I have a form that passes the $title and $content variables to the function. It always tells me it "couldn't add contents foo!" (the die statement for the query). Now, if I copy the query and run it from the command line it works. So the query has to be fine. Wouldn't it tell me it couldn't connect if the username and password weren't right? I checked that the fields in the table were right. BTW, mySQL is installed on a Windows NT 4 system, under IIS 4. The service is running. I can run SQL statements just fine from PHPmyAdmin.

I'm frustrated... Thanks for any help. It's probably some simple thing and I am just retarded.

Thanks!
Chad

eojlin

Hi,

i think you got the $db incorrect. you passed the link identifier not the database.
$db should contain the name of your database not the link to your DBMS.

you should do it like this:

function addMainPage($title, $content) {
$dblink = mysql_connect("localhost", "root", "") or die("Could not connect");
$db = "someDBname";
$query = "INSERT INTO mainpage (title, content) VALUES ('$title', '$content');";
mysql_db_query("$db", "$query") or die("Couldn't add contents foo!");
mysql_close($dblink);

}

Anon

else u can do these too
$host = 'localhost';
$user = 'php';
$pass = 'mysql';
$database = 'intranet';
$connect = mysql_connect ( $host,$user,$pass) or die ("cannot connect ");
$db = mysql_select_db($database);

then $query = " ------ ";
$result = mysql_query($query);

this should works
mandar

Anon

hmmm, still no go. I wonder what is wrong? It's not clicking...

This is my code now:

function addMainPage($title, $content) {
$host = 'localhost';
$user = 'root';
$pass = '';
$database = 'intranet';
$connect = mysql_connect ($host,$user,$pass) or die (" cannot connect ");
$db = mysql_select_db($database);
$query = "INSERT INTO mainpage (title, content) VALUES ($title, $content);";
$result = mysql_query($query);
}

if I echo the $title and $content variables I get the values that are passed from the HTML form. So I know these values are ok. I know I shouldn't use root user and no password, but I am just trying to get it to work right now. So my database name is 'intranet' and the table name is 'mainpage'. The sql query is correct because I can paste it into PHPmyAdmin and it works.

I'm lost...

jc94062

Not sure if this will help but try altering the connect stuff...

$connect = mysql_connect ($host,$user,$pass) or die (" cannot connect ");
$db = mysql_select_db($database);

into

$db = mysql_connect("$host", "$user", "$pass"); or die ("Failed to Connect");
mysql_select_db("$database",$db);

Let me know if it works

Anon

I had to delete the ; after the mysql_connect funtion James wrote, because it gave me a parse error... Didn't matter though, it still doesn't work. So here is my code now:

function addMainPage($title, $content) {
$host = 'localhost';
$user = 'root';
$pass = '';
$database = 'intranet';
$table = 'mainpage';
$db = mysql_connect("$host", "$user", "$pass") or die ("Failed to Connect");
mysql_select_db($database, $db);
$query = "INSERT INTO $table (title, content) VALUES ($title, $content);";
$result = mysql_query($query) or die (" couldn't add content ");
mysql_close($db);
}

I'm thinking there has to be something up with the server. Any ideas?

Thanks again...
Chad

Anon

This works!

function addMainPage($title, $content) {
$host = 'localhost';
$user = 'root';
$pass = '';
$database = 'intranet';
$table = 'mainpage';
$db = mysql_connect("$host", "$user", "$pass") or die ("Failed to Connect");
$query = "INSERT INTO $table (title, content) VALUES ('$title', '$content')";
mysql_db_query($database, $query) or die (" couldn't add content ");
mysql_close($db);
}

The culprit was the exta ';' in the query. Damn, can't believe I did that... ugh. Now I just need to change the user.

Thanks for all the help!
Chad

kparker

Chad (and everyone else!)

If you want to decrease the time it takes to debug these kind of database problems, be sure to include the value of $php_errormsg in your output from die(). The mysql module (and many others, too, e.g. postgresql) provide fairly informative feedback about exactly what went wrong.