I'm going MAD!! what's wrong with this?

[Anon]

I'm trying to do a shopping cart feature, and it works really well with a sample script, but when I try to implement it on a longer scripts (with functions)

errors occur..

something like "header already sent on line blah blah" (the line is one the Setcookie() line)

here're parts of my scripts:

main store script:

$tablestore = "shopping";
include( "shoppingcart.php3");

$cart = new Cart;

//if(!$cookies)
//$cookies = $session;
require($carcloak[$page].".inc");

if($add)
{
if($cookies)
$session = $cookies;

 $result = mysql_query(  "SELECT * FROM car_record WHERE id='$add'");
 $row = mysql_fetch_array($result);

 $cart->add_item($tablestore,$session,$row[id])

}

function somefunction() {

global $REQUEST_URI,$session,$cookies;

while($row = mysql_fetch_array($result))
		{ 

echo "<tr><FORM ACTION='ecs_database.php3' METHOD=post><td bgcolor=$color><center><font face=verdana size=1>$row[counter]</font></center></td>\n";

		echo "<td bgcolor=$color><CENTER><A HREF=\"$REQUEST_URI&add=".urlencode($row[id]);

if (!$cookies)
echo "&session=$session\">";
else
echo "\">";

}

---

shoppingcart.php3

if(!$session && !$cookies) //make sure this hasn't already been established
{
$session = md5(uniqid(rand())); //creates a random session value

Setcookie( "cookies", "$session",time()+7200);
}
class Cart
{

function add_item($tablestore, $session,$id)
{
// Checks to see if they already have that id in their list
$in_list = "SELECT * FROM $tablestore WHERE session='$session' ";
$in_list .= "AND id='$id'";
$result = mysql_query( "$in_list");
$num_rows = mysql_num_rows($result);

        // they don't have that id in their cart?  Put it in. 
       if($num_rows == 0)
       {
          $sql =  "INSERT INTO $tablestore (session,id) VALUES ";
          $sql .=  "('$session','$id')";
          mysql_query( "$sql");


       }

---

Someboy enlighten me.. 🙁

im going nuts.

Thanks!!!!!

[Anon]

Yihung, I don't know if this is the problem, but check you include files for any empty lines before the <?php of after the ?> tags. PHP treats empty lines (carriage returns) as a space and sends it at HTML, so if there are any, it sends the header before the cookie can be set. That's why you would get a "Header already sent" message when trying to set a cookie.

If that's not it, just make sure there are no empty lines above the setcookie() function.

If that's not it, I don't know what to tell you.

Good luck.

[Anon]

sorry, that's not it..

[techek]

I suppose the script you're trying to use and make uses cookies to implement a part of the Cart-system.

Cookies are much like HTTP-headers and the first rule to stick to in PHP is that headers must be set (using HEADER()) in the very beginning of the output. Not nesessarilly (damn I spell like s..t!) in the top of your script, but BEFORE any output at all - including whitespace and such as Ryan points out.

So, when I look at your code I guess that one or both of your scripts has some returns or whitespace before the <?php ?> part. Anyway, let me know if I can help you later on!

Hint : Go have a look at those setcookie() and header() functions s

[Anon]

Hi Techek,

thanks for your response in phpbuilder.. I think Ryan's suggestion helped after deleting the whitespace.. I didn't get a chance to test it last night..

however, I'm having another problem.. it's session/cookies problem..

please look at the very simplified codes at

http://members.home.net/yihung/storescript.txt

http://members.home.net/yihung/shoppingcart2.php3.txt

1) from the store script , it shows that the first time a user click on the link, the session number should be shown.. it doesnt.

2) from the shoppingcart script, it shows that if id and session numbers match, the script shouldnt add the record again.. but it DOES!!! I have no idea why.

3) in the store script, i use request_uri .. but you see the problem is that the url gets larger and larger (with &add=#).. I tried ereg_replace function to replace add and session.. but the problem is that if the use already set a session, then &session=$session shouldnt appear, then the replace function wont work..

what I tried was

ereg_replace("&add=([0123456789]+)&session=([0123456789]+)", "&add=$row[id]&session=$session", "$REQUEST_URI")

Do you have any advice on how to code it so the url doesnt increase?

Thanks a lot!