HELP ME, Im going Crazy!

Anon

Hello all,
I have spent the past 4-5 hours trying to figure out why this code does not delete the selection I want. It uses checkboxes and it doesnt want to do its job. Can someone please look at this following code and tell me what's wrong with it?

<?php
include("../config.inc");

//Connects to MySQL database
$link = mysql_connect("$host", $user, $pass);
if(!$link) die ("Couldnt connect to MySQL database");
mysql_select_db($data, $link) or die ("Couldnt open $data: ".mysql_error());

$query = "SELECT FROM acidnews ORDER BY id DESC";
$result = mysql_query($query);
$num = mysql_num_rows($result);
$acidnews = mysql_query("SELECT FROM acidnews ORDER BY id DESC");
$i = 0;

if(isset($delete))
{
$sql = "DELETE FROM acidnews WHERE id=$row2[id]";
$result2 = mysql_query($sql);
$row2 = mysql_fetch_array($acidnews);
print "Number $row2[id] Record deleted<br>";
}
if($num <= $i)
{
print "There is currentlly no news in the archive.";
}
elseif($num == 1)
{
print "There is currentlly $num news artical in the archive";
}
elseif($num > $i)
{
print "There are curentlly $num news articals in the archive. <p>";
while($row = mysql_fetch_array($acidnews))
{
print "<form name=\"delete\" action\"$PHP_SELF\" method=\"POST\"><table width=\"500\" border=\"1\" cellspacing=\"0\" cellpadding=\"0\" bordercolor=\"#000066\" align=\"center\">
<tr bgcolor=\"#666666\">
<td width=\"2\"><font color=\"#FFFFFF\"><div align=\"center\"><b>$row[id]</b></div></td>
<td width=\"498\"><font color=\"#FFFFFF\"><b>$row[title] </b></font>Submitted by: $row[submitby]</td>
</tr>
<tr>
<td width=\"2\"><input type=\"checkbox\" name=\"delete\" value=\"checkbox\"></td>
<td width=\"498\">$row[body]</td>
</tr>
<tr>
<td width=\"2\"> </td>

<td width=\"498\"><div align=\"right\"></div></td>";

print "</tr>
</table><br>";

}
print "</table></center>\n";
print "<input type=\"submit\" name=\"Submit\" value=\"Submit\"><form>";
mysql_close($link);
}
?>

</body>

mdmann

Since you haven't described exactly what
you are seeing, my first guess would be
that you need to enclose the argument to
the the array row2 in quotes in the line

$sql = "DELETE FROM acidnews WHERE id=$row2[id]

thus, $row2["id"]

Actually, I think you need those quotes
in every instance of your use of $row2[id].
What are you seeing when you run this
script?

Michael

Anon

its not deleting from the MySQL database. What i am trying to do is create an admin panel that will delete news articals from the MySQL database. The php will return all the news articals in DESC (which makes it 3,2,1 instead of 1,2,3) and have a checkbox next to each one so that the admin can delete the selected news artical.

jc94062

I think what he meant was something along the lines...

$sql = "DELETE FROM acidnews WHERE id='$id_to_delete'

where

$id_to_delete = $row2["id"]

would be set up in a while loop.

mdmann

Ray,

Every place where you use $row2[id], I
think you need to put id in quotes, i.e.,

$row2["id"]

I would have thought you'd get some kind
of error message without the quotes, that's
why I was asking what you saw when you
tried to run the script.

Michael

Anon

yes, what i have so far is something like $sql = "DELETE FROM acidnews WHERE id=$row[id]" and if i try to put that in a while statement it tweaks out on me. It deletes everything (well doesnt delete it, it just says it does.). The only problem i am having, is actually getting the line of code to follow through and actually delete from the MySQL database.

Anon

wow, i got something to sort of work. I got it so it sort of deletes the last id. But if you go back and hit refresh it comes back. Right now I have this code:

<?php
include("../config.inc");

//Connects to MySQL database
$link = mysql_pconnect("$host", $user, $pass);
if(!$link) die ("Couldnt connect to MySQL database");
mysql_select_db($data, $link) or die ("Couldnt open $data: ".mysql_error());

$query = "SELECT FROM acidnews ORDER BY id DESC";
$result = mysql_query($query);
$num = mysql_num_rows($result);
$acidnews = mysql_query("SELECT FROM acidnews ORDER BY id DESC");
$i = 0;

if(isset($delete))
{
$sql = ("DELETE FROM acidnews WHERE id=$row[id]");

$result2 = mysql_query($sql);
$row2 = mysql_fetch_array($acidnews);
print "Number $row2[id] Record deleted<br>";
}
if($num <= $i)
{
print "There is currentlly no news in the archive.";
}
elseif($num == 1)
{
print "There is currentlly $num news artical in the archive";
}
elseif($num > $i)
{
print "There are curentlly $num news articals in the archive. <p>";
while($row = mysql_fetch_array($acidnews))
{
print "<form name=\"delete\" action\"$PHP_SELF\" method=\"POST\"><table width=\"500\" border=\"1\" cellspacing=\"0\" cellpadding=\"0\" bordercolor=\"#000066\" align=\"center\">
<tr bgcolor=\"#666666\">
<td width=\"2\"><font color=\"#FFFFFF\"><div align=\"center\"><b>$row[id]</b></div></td>
<td width=\"498\"><font color=\"#FFFFFF\"><b>$row[title] </b></font>Submitted by: $row[submitby]</td>
</tr>
<tr>
<td width=\"2\"><input type=\"checkbox\" name=\"delete\" value=\"checkbox\"></td>
<td width=\"498\">$row[body]</td>
</tr>
<tr>
<td width=\"2\"> </td>

<td width=\"498\"><div align=\"right\"></div></td>";

print "</tr>
</table><br>";

}
print "</table></center>\n";
print "<input type=\"submit\" name=\"Submit\" value=\"Submit\"><form>";
}
?>

</body>

and thats all of it.

Anon

ok forget all that now, i got it, sorta. All i need to know (or do) is fix something. I put it in a while statement, i want it to be: if you check a box, that news artical will be deleted, but the way it is working, is that it is saving the checked ones and deleting the others. If you want to see the code it is:

<?php
include("../config.inc");

$query = "SELECT FROM acidnews ORDER BY id DESC";
$result = mysql_query($query);
$num = mysql_num_rows($result);
$acidnews = mysql_query("SELECT FROM acidnews ORDER BY id DESC");
$i = 0;

if(isset($delete))
{
while($row = mysql_fetch_array($acidnews))
{

$sql = ("DELETE FROM acidnews WHERE id=$row[id]");

$result2 = mysql_query($sql);
$row2 = mysql_fetch_array($acidnews);
print "Number $row2[id] Record deleted<br>";
}
}
if($num <= $i)
{
print "There is currentlly no news in the archive.";

}
elseif($num == 1)
{
print "There is currentlly $num news artical in the archive";
while($row = mysql_fetch_array($acidnews))
{
print "<form name=\"delete\" action\"$PHP_SELF\" method=\"POST\"><table width=\"500\" border=\"1\" cellspacing=\"0\" cellpadding=\"0\" bordercolor=\"#000066\" align=\"center\">
<tr bgcolor=\"#666666\">
<td width=\"2\"><font color=\"#FFFFFF\"><div align=\"center\"><b>$row[id]</b></div></td>
<td width=\"498\"><font color=\"#FFFFFF\"><b>$row[title] </b></font>Submitted by: $row[submitby]</td>
</tr>
<tr>
<td width=\"2\"><input type=\"checkbox\" name=\"delete\" value=\"checkbox\"></td>
<td width=\"498\">$row[body]</td>
</tr>
<tr>
<td width=\"2\"> </td>

<td width=\"498\"><div align=\"right\"></div></td>";

print "</tr>
</table><br>";

}
print "</table></center>\n";
print "<input type=\"submit\" name=\"Submit\" value=\"Submit\"><form>";
}

elseif($num > $i)
{
print "There are curentlly $num news articals in the archive. <p>";
while($row = mysql_fetch_array($acidnews))
{
print "<form name=\"delete\" action\"$PHP_SELF\" method=\"POST\"><table width=\"500\" border=\"1\" cellspacing=\"0\" cellpadding=\"0\" bordercolor=\"#000066\" align=\"center\">
<tr bgcolor=\"#666666\">
<td width=\"2\"><font color=\"#FFFFFF\"><div align=\"center\"><b>$row[id]</b></div></td>
<td width=\"498\"><font color=\"#FFFFFF\"><b>$row[title] </b></font>Submitted by: $row[submitby]</td>
</tr>
<tr>
<td width=\"2\"><input type=\"checkbox\" name=\"delete\" value=\"checkbox\"></td>
<td width=\"498\">$row[body]</td>
</tr>
<tr>
<td width=\"2\"> </td>

<td width=\"498\"><div align=\"right\"></div></td>";

print "</tr>
</table><br>";

}
print "</table></center>\n";
print "<input type=\"submit\" name=\"Submit\" value=\"Submit\"><form>";
}
?>

</body>

mdmann

Two suggestions, in addition to the one
already made about enclosing id in quotes:

1) Echo the DELETE query string so you
can see exactly what is being passed to
the database.

2) Enable some error checking and reporting
by coding each of the mysql_query()
statements as

$result = mysql_query($query_string)
or die ("Query failed: " . mysql_error());

With these suggestions, you can make sure
you are telling the database to do exactly
what you thought you were, and if there is
some error, you will have some idea as to
what went wrong.

Michael

Anon

ok, well i did that and i got no errors and i checked the code and what not. Anyways, I figured out some bug or something like that:

Say I have 10 news articals, I want to delete one of them, so i check off the box, then it SHOULD delete that one news artical that i checked off. In my case, i tried this and it deleted all the even numbers. I don't know what i did wrong.

mdmann

Does the echo of the query you pass to the
database show that you should have deleted
only one news article and not all of the
even ones?

Anon

how should i write the echo?

mdmann

Ray,

Sorry, I had to go away for a few hours.

Right after you set the query string with
the DELETE in it, but before you execute
the mysql_query() command, insert

echo "<BR>$query";

The "<BR>" will make each invocation
echo to a new line (since you have this in
a while loop, this will make it easier to
see)

Michael

Anon

this is what i get when i echo it:

SELECT * FROM acidnews ORDER BY id DESC

mdmann

OK, that's one of the query strings, but
not the one you are really interested in.
I suggested putting it after the one
with the DELETE directive in it. That's
the query that you have the question about.

Michael

Anon

I figured out what is going on, and I think it has to do with the submit or something. What it does, is for every one checkbox that is checked off, it deletes 3 fields from the MySQL database.