Odd behaviour

techmeister

Hi all:

The function below (is long but it's just the forst couple of lines that are bothering me) Why does the first part of my display table echo itslef twice? Once at the very top of the page (outside the <head>)and the second time where it should be, in the body of the page??

<?php
//Recurse thru directory, & get its contents
//$scanthis = Dir to be analaysed
//$rootDir = Dir to take as root
function parse_dir($scanthis) {
$dir = @opendir($scanthis);
$dispThis = "<table width=\"100%\" border=\"0\" cellpadding=\"2\" cellspacing=\"1\"><tr><th align=\"left\">Filename</th><th align=\"left\">Filesize</th><th align=\"left\">Modified on</th></tr>";
while (false!=($file = @readdir($dir))) {
if ($file != "." && $file != "..") {
if (is_dir($scanthis."/".$file)) {
echo "
<img src=\"path/to/root/dir/images/dir.gif\" border=\"0\">" . " " . $scanthis . "/" . $file . " is a directory containing the following files: ";
parse_dir($scanthis."/".$file,$level+1);
}
//$fa = $scanthis."/".$file;
//$fu = filesize("$scanthis/$file");
else {
$fu = round(filesize("$scanthis/$file")/1000,2);
//regexp = /\s/g;
$scanthispp = preg_replace("/\s/","%20",$scanthis);
$filep = preg_replace("/\s/","%20",$file);
if ($filep != '.htaccess') {
//Get last modified date of file
$theFile = $scanthispp . "/" . $filep;
$modDate = filemtime($theFile);
$modDate = date("d-m-Y H:i", $modDate);
$dispThis .= "<tr><td align=\"left\"><a href=\"$scanthispp/$filep\">$file</a></td><td align=\"left\">Size: $fu K</td><td align=\"left\">$modDate</td></tr>";
}//end-if
}//end-else
}//end-if
}//end-while
$dispThis .= "</table>";
echo $dispThis;
}//end-function declaration

$rootDir = "path/to/root/dir";
$level = 1;
parse_dir($rootDir, $level);
//closedir($rootDir);

Basically: The first '$dispThis ' is echoes twice. Why?

ANy help would be much appreciated.
Regards:

Russ

techmeister

Relax - I sorted it, just embedded the first table section in the page, dynamically produced the rest.

Russ

Anon

It's very tough to make head or tails of this function. You are trying to do too much in 1 function. A function should do one thing, and do it well. You have this function trying to do several different things. I am not trying to critisize, but you'll find it much easier to debug if you break things down to more specifc uses.

Also, keep your comments inside the function to a bare minmum. Sorry to be critical, just trying to help. And this is part of your problem, it's making it difficult for you to see what your doing.

I can't see exactly where the problem pops up, but you have a recursive funtion, it's calling itself in your while statement, I am sure that is the root of the problem. You need to be very careful with recursive functions.

If you break up the function, you should be able to avoid the problem.

It's better practice to have a function return a variable and then echo it, rather than have the function echo the variable itself.