Determining if a file input type is set

Anon

I have a little problem, well duh. Anyway, I can't figure out how to have php tell if :

is set when the form is submitted.

the form is multi part, it has a file and some text fields

i have tried strlen and some other things and they wont work either.

here is the page:

<?PHP
include("dblib.php");
include("memlib.php");
$message = " ";
$page = "info";

CHECK COOKIE-->

if(isset($famname) && isset($fampass) )
{

if (!($row_array = checkCook($famname, $fampass) ) )
$message .= "wrong password";
}
else
{
header("Location: login.php");
}

global $link;
$query4 = "SELECT id FROM members WHERE login='$famname'";
$result4 = mysql_query($query4);
while(list($id) = mysql_fetch_row($result4))
{

if (isset($action) && $action == "info")
{

if(isset($picture))
{

$data = addslashes(fread(fopen($picture, "r"), filesize($picture)));

 global $link;
 $query = "UPDATE members set mail='$mail', firstn='$firstn', lastn='$lastn', age='$age', gender='$gender', location='$location', job='$job', pic='$data', filetype='$picture_type' WHERE login='$famname'";
 $result = mysql_query($query, $link);

if ( ! $result )
die("Updating Error");
header("Location: menu.php");
exit;
}
else
{
global $link;
$query = "UPDATE members set mail='$mail', firstn='$firstn', lastn='$lastn', age='$age', gender='$gender', location='$location', job='$job', WHERE login='$famname'";
$result = mysql_query($query, $link);
if ( ! $result )
die("Updating Error");
header("Location: menu.php");
exit;
}

}
}
include("nav.inc");

global $link;
$query = "SELECT firstn, lastn, age, gender, location, job, mail, id FROM members WHERE login='$famname'";
$result = mysql_query($query);
while(list($firstn, $lastn, $age, $gender, $location, $job, $mail, $id) = mysql_fetch_row($result))
{

?>
<BODY BGCOLOR=5D69FD link="#000000" vlink="#000000" alink="#000000" text="#000000">
<FONT FACE=VERDANA SIZE=2>
<FORM enctype="multipart/form-data" method="post">
<INPUT TYPE="HIDDEN" NAME="action" VALUE="info">
<INPUT TYPE="HIDDEN" NAME="MAX_FILE_SIZE" value="20000">

<BR>

General Info
<BR>
First Name:
<BR>
<?PHP
print ("
<input type=text name=firstn value=\"$firstn\" $signstyle maxlength=\"40\">
");
?>
<BR>
Last Name:
<BR>
<?PHP
print ("
<input type=text name=lastn value=\"$lastn\" $signstyle maxlength=\"40\">
");
?>
<BR>
Age:
<BR>
<?PHP
print ("
<input type=text name=age value=\"$age\" $signstyle maxlength=\"2\">
");
?>
<BR>
<BR>
Gender:
<BR>
<?PHP
print ("
<input type=text name=gender value=\"$gender\" $signstyle maxlength=\"1\">
");
?>
<BR>
Location:
<BR>
<?PHP
print ("
<input type=text name=location value=\"$location\" $signstyle maxlength=\"40\">
");
?>
<BR>
Occupation:
<BR>
<?PHP
print ("
<input type=text name=job value=\"$job\" $signstyle maxlength=\"50\">
");
?>
<BR>
WHAT IS THY EMAIL, MY MASTER?
<BR>
<?PHP
print ("
<input type=text name=mail value=\"$mail\" $signstyle maxlength=\"50\">
");
?>
<BR>
<BR>
Personal Pic: (leave alone unless your changing it)
<BR>

<?PHP
}
?>

Everything works if you have a picture file, but how can i make it work if you dont?

mithril

BJ,

You want to check the $HTTP_POST_FILES array to make sure that a file has indeed been uploaded. The $HTTP_POST_FILES array is comprised of 4 key's:

name => the name of the file from the user's filesystem
tmp_name => name of the uploaded file stored in the server's tmp directory
type => the mime-type of the uploaded file
size => the byte size of the uploaded file

If no file was uploaded, then $HTTP_POST_FILES[tmp_name] == "none". You can view the array by calling phpino() on the form's target page. HTH,

Cheers,

Geoff A. Virgo

Anon

I changed it to this:

<?PHP
include("dblib.php");
include("memlib.php");
$message = " ";
$page = "info";

CHECK COOKIE-->

if(isset($famname) && isset($fampass) )
{

if (!($row_array = checkCook($famname, $fampass) ) )
$message .= "wrong password";
}
else
{
header("Location: login.php");
}

global $link;
$query4 = "SELECT id FROM members WHERE login='$famname'";
$result4 = mysql_query($query4);
while(list($id) = mysql_fetch_row($result4))
{

if (isset($action) && $action == "info")
{

if($HTTP_POST_FILES[tmp_name] != "none")
{

$data = addslashes(fread(fopen($picture, "r"), filesize($picture)));

 global $link;
 $query = "UPDATE members set mail='$mail', firstn='$firstn', lastn='$lastn', age='$age', gender='$gender', location='$location', job='$job', pic='$data', filetype='$picture_type' WHERE login='$famname'";
 $result = mysql_query($query, $link);

if ( ! $result )
die("Updating Error");
header("Location: menu.php");
exit;
}
elseif($HTTP_POST_FILES[tmp_name] == "none")
{
global $link;
$query = "UPDATE members set mail='$mail', firstn='$firstn', lastn='$lastn', age='$age', gender='$gender', location='$location', job='$job', WHERE login='$famname'";
$result = mysql_query($query, $link);
if ( ! $result )
die("Updating Error");
header("Location: menu.php");
exit;
}

}
}
include("nav.inc");

<BR>

<?PHP

if ($message != " ") {
print "$message";
}
}

But it still does not seem to work, I don't really understand what you meant, could you fix this maybe?

thanks a lot!

mithril

BJ,

You've only half fixed the problem by using the $HTTP_POST_FILES array to check if a picture was uploaded. Problem in your script is, and perhaps I didn't explain it properly, the $HTTP_POST_FILES array is actually a two-dimensional array where the first key element is the name of the file element from the submitting form. Therefore in your example, the structure becomes:

$HTTP_POST_FILES[picture][name]
$HTTP_POST_FILES[picture][type]
$HTTP_POST_FILES[picture][tmp_name]
$HTTP_POST_FILES[picture][size]

Based on this, you'll need to change all instances of "$HTTP_POST_FILES[tmp_name]" to "$HTTP_POST_FILES[picture][tmp_name]" for the file upload check to work.

Now, the second problem is in your call to fopen and fread the uploaded file. When called directly in a script, the value of a file form element is treated the same as a text element. That is, echoing it will print the string contained in the box. Since in a file element that text box will contain the path to the file on the remote (read: user's) box, it's useless as far as the server is concerned. You should be able to fix the remaining file upload problem by changing the line:

$data = addslashes(fread(fopen($picture, "r"), filesize($picture)));

to read:

$data = addslashes(fread(fopen($HTTP_POST_FILES[picture][tmp_name], "r"), filesize($picture)));

It appears from your script that you are storing the actual image data in your db as a blob. If this is the case, changing the above should be all that's needed. If you were storing the uploaded images on your servers hard disk, you'd need to do something like:

$newFilePath = "/var/www/htdocs/bj-land/images/";

// to create a new file name
$newFileName = "uploaded_image.jpg";

// or, to keep the same file name as the remote user

$newFileName = $HTTP_POST_FILES[picture][name];

$newFile = $newFilePath . $newFileName;

copy($newFile, $HTTP_POST_FILES[picture][tmp_name]);

making sure that the webserver user account (usually www-data on *Nix and IUSR_machinename on NT/Win2K) has the appropriate permissions to write files into the specified directory. Does this clear up your questions/problems? HTH.

Cheers,

Geoff A. Virgo

mithril

Opps,

In my previous post, the line:

$data = addslashes(fread(fopen($HTTP_POST_FILES[picture][tmp_name], "r"),
filesize($picture)));

should read:

$data = addslashes(fread(fopen($HTTP_POST_FILES[picture][tmp_name], "r"),
filesize($HTTP_POST_FILES[picture][size])));

Sorry 'bout that:-}

Geoff

Anon

heres what i have now:

<?PHP
include("dblib.php");
include("memlib.php");
$message = " ";
$page = "info";

CHECK COOKIE-->

if(isset($famname) && isset($fampass) )
{

if (!($row_array = checkCook($famname, $fampass) ) )
$message .= "wrong password";
}
else
{
header("Location: login.php");
}

global $link;
$query4 = "SELECT id FROM members WHERE login='$famname'";
$result4 = mysql_query($query4);
while(list($id) = mysql_fetch_row($result4))
{

if (isset($action) && $action == "info")
{

if($HTTP_POST_FILES[picture][tmp_name] != "none")
{

$data = addslashes(fread(fopen($HTTP_POST_FILES[picture][tmp_name], "r"),
filesize($HTTP_POST_FILES[picture][size])));

 global $link;
 $query = "UPDATE members set mail='$mail', firstn='$firstn', lastn='$lastn', age='$age', gender='$gender', location='$location', job='$job', pic='$data', filetype='$picture_type' WHERE login='$famname'";
 $result = mysql_query($query, $link);

if ( ! $result )
die("Updating Error1");
header("Location: menu.php");
exit;
}
elseif($HTTP_POST_FILES[picture][tmp_name] == "none")
{
global $link;
$query = "UPDATE members set mail='$mail', firstn='$firstn', lastn='$lastn', age='$age', gender='$gender', location='$location', job='$job' WHERE login='$famname'";
$result = mysql_query($query, $link);
if ( ! $result )
die("Updating Error2");
header("Location: menu.php");
exit;
}

}
}
include("nav.inc");

<BR>

<?PHP

if ($message != " ") {
print "$message";
}
}

?>
Im uploading the picture to a database as a blob, but it seems as if it's not taking the picture and just writing nothing over the picture file, so its working now, but it's not taking the picture to upload... what do i do??

and Thanks so much for all of your help so far!!! you rock!!!

Anon

mithril

Hmmmm...... silly me, more brain-to-finger farts!!!

Here's your problem:

$data = addslashes(fread(fopen($HTTP_POST_FILES[picture][tmp_name], "r"), filesize($HTTP_POST_FILES[picture][size])));

There's no need to call filesize() if you're using $HTTP_POST_FILES[picture][size]..... it already is the filesize🙂 Change:

filesize($HTTP_POST_FILES[picture][size])

to read either:

filesize($HTTP_POST_FILES[picture][tmp_name])

or:

$HTTP_POST_FILES[picture][tmp_name]

When I echo the contents of the $data variable with either of those changes made, it spits out the "garabge" chars represent the image's binary data. This should solve your problem. Let me know if it still doesn't work. HTH.

Cheers,

Geoff A. Virgo

Anon

IT WORKS!!!!!
(and I tested it all sorts of ways, so im positive)

Thanks so much for all your help mank!

your my hero.

cya