Hey! I'm working with a newsscript and I can't get this edit/update function to work.
It reads all variables right to start with (and fills out the form), but when I press Update it seems to update but nothing happens in the database.
I'm greatful for any help.
This is the function that doesn't work:
function editnews(){
include "mm_config.php";
$mm_config["sqlconnect"];
$mm_config["selectdb"];
global $NewsId;
$sql = mysql_query("SELECT * FROM topnews WHERE NewsId = $NewsId");
while ($row = mysql_fetch_array($sql)) {
extract($row);
echo "<head><title>Modify News</title></head>
<body bgcolor=\"#FFFFFF\" text=\"#000000\">
<form action=\"$PHP_SELF?apa=edit&$Update\" method=GET>
<input type=\"hidden\" name=\"NewsId\" value=\"$NewsId\">
NewsID: $NewsId<br>
NewsDate: $NewsDate<br>
Headline<br>
<input type=\"text\" name=\"NewsHeader\" value=\"$NewsHeader\">
<br>
Newstext<br>
<textarea value=\"$NewsText\" name=\"NewsText\" cols=\"55\" rows=\"4\">$NewsText</textarea>
<br>
NewsLink1<br>
<input type=\"text\" name=\"NewsLink1\" value=\"$NewsLink1\">
<br>
LinkName1<br>
<input type=\"text\" name=\"LinkName1\" value=\"$LinkName1\">
<br>
External1<br>
";
if ($External1 != 'target=ext_win') {
echo "<input type=\"checkbox\" name=\"External1\" value=\"target=ext_win\"> ";
};
if ($External1 == 'target=ext_win') {
echo "<input type=\"checkbox\" name=\"External1\" value=\"target=ext_win\" checked> ";
};
echo "
<br>
NewsLink2<br>
<input type=\"text\" name=\"NewsLink2\" value=\"$NewsLink2\">
<br>
LinkName2<br>
<input type=\"text\" name=\"LinkName2\" value=\"$LinkName2\">
<br>
External2<br>
";
if ($External2 != 'target=ext_win') {
echo "<input type=\"checkbox\" name=\"External2\" value=\"target=ext_win\"> ";
};
if ($External2 == 'target=ext_win') {
echo "<input type=\"checkbox\" name=\"External2\" value=\"target=ext_win\" checked> ";
};
echo "
<br>
NewsLink3<br>
<input type=\"text\" name=\"NewsLink3\" value=\"$NewsLink3\">
<br>
LinkName3<br>
<input type=\"text\" name=\"LinkName3\" value=\"$LinkName3\">
<br>
External3<br>
";
if ($External3 != 'target=ext_win') {
echo "<input type=\"checkbox\" name=\"External3\" value=\"target=ext_win\"> ";
};
if ($External3 == 'target=ext_win') {
echo "<input type=\"checkbox\" name=\"External3\" value=\"target=ext_win\" checked> ";
};
echo "
<br>
<input type=\"submit\" name=\"Update\" value=\"Update\">
<input type=\"submit\" name=\"Delete\" value=\"Delete\">
</form></body>";};
if($Update) {
$query = "UPDATE topnews SET NewsHeader = '$NewsHeader',NewsText = '$NewsText', NewsLink1 = '$NewsLink1', LinkName1 = '$LinkName1', External1 = '$External1', NewsLink2 = '$NewsLink2', LinkName2 = '$LinkName2', External2 = '$External2', NewsLink3 = '$NewsLink3', LinkName3 = '$LinkName3', External3 = '$External3' WHERE NewsId = '$NewsId'";
$result = mysql_query($query);
print ($NewsHeader);
print ("<br>");
print ($NewsId);
};
};
switch($apa)
{
case "choose": selectnews();
break;
case "edit": editnews();
break;
case "update": updatenews($NewsHeader, $NewsText, $NewsLink1);
break;
default: addnews();
break;
}
I just don't get it...
