Where is coding error?

[Anon]

<?

define("MaxFileSize", 100000);

save_banner_pic("Picture");

function save_banner_pic($file)
{
	$file_type = $file."_type";
	$file_size = $file."_size";
	$file_name = $file."_name";

	global $$file;
	global $$file_name;
	global $$file_type;
	global $$file_size;

	if( !$$file_name )
		return false;

	if( !file_exists($$file) )
		return false;

	if( $$file_type != "image/pjpeg" && $$file_type != "image/gif" && $$file_type != "image/png" )
		return false;

	if( $$file_size > MaxFileSize )
		return false;

	echo "Picture = ".$$file."<br>";
	echo "Picture_name = ".$$file_name."<br>";
	echo "Picture_type = ".$$file_type."<br>";
	echo "Picture_size = ".$$file_size."<br>";

	if( !$image = ImageCreateFromGIF($$file) )
		if( !$image = ImageCreateFromJPEG($$file) )
			if( !$image = ImageCreateFromPNG($$file) )
				return false;

	$width = imagesx($image);
	$height = imagesy($image);
	echo "Picture_width = ".$width."<br>";
	echo "Picture_height = ".$height."<br>";

	$pos = strpos($$file_name,".");
	$new_name = substr($$file_name,0,$pos);
	$ext = substr($$file_name,$pos);
	while( file_exists("Images/".$new_name.$ext) )
	{
		$new_name = rand();
	}

	if( copy($$file,"Images/".$new_name.$ext) )
		return $new_name.$ext;
	else
		return false;
}

?>

[theslinky]

Hi,

Can you please tell us what the PHP reported? It is really tedious for anyone to go through lines of code. So if you have any additional info like on what line it breaks or messages/errors from the PHP, please post them

thanks
-sridhar

[Anon]

Picture = /tmp/phpeEWDIG
Picture_name = 56.jpg
Picture_type = image/pjpeg
Picture_size = 28983

Warning: ImageCreateFromGif: No GIF support in this PHP build in /var/www/html/Uugan/save_pic.php on line 35

Warning: ImageCreateFromJpeg: No JPEG support in this PHP build in /var/www/html/Uugan/save_pic.php on line 36

Warning: imagecreatefrompng: '/tmp/phpeEWDIG' is not a valid PNG file in /var/www/html/Uugan/save_pic.php on line 37

[dstockto]

Sounds like you need to compile or link the GD stuff into your PHP. I don't have a lot of experience on linux with PHP and image creation, but it seems like you don't have a syntax error, but are missing some PHP stuff you are calling.

Dave

[Anon]

Hi Dave Stockton, thanks for your help.