page counter

[Anon]

hi
ok, i want to make a script that does the following:
i already have a script so when someone on the staff submits an article, it adds a row to a certain mysql table in a database. that table has 2 columns, one is the ID of the item that was submited, the second is the # of hits the item has (defaults to 0). now, how can i make the actual item do this:
check if the person has been to this very certain item, if not, add a cookie and add 1 to the row of this item in the hits table.... right now, i have everything but the part where it checks if they have been here and cookie adding, waht i need to know is how to generate a cookie name based on the ID of the item

[inlandpac]

Here you go:

<?php
$dbcon = mysql_pconnect("host","username","password");
@mysql_select_db("database",$dbcon);

//expiration of 1 year
$exp = time() + (606024*365);

function update_hits() {
global $this_page_id;

 $q = "SELECT COUNT(*) FROM hits WHERE page_id='$this_page_id'";
 $r = mysql_query($q);
 $n = mysql_fetch_row($r);

 if($n[0] < 1) {
      $q = "INSERT INTO hits (page_id, hits) VALUES ('$this_page_id', '1')";
 }
 else {
      $q = "UPDATE hits SET hits=hits+1 WHERE page_id='$this_page_id'";
 }

 if(!mysql_query($q)) {
      return mysql_error();
 }
 else {
      return 0;
 }

}

if(!$visit_data) {

 if(update_hits()) {
           echo "an error has occured! ".mysql_error();
           die();
 }
 else {
      setcookie("visit_data[0]",$this_page_id,$exp);
 }

}
else {

 if(!in_array($this_page_id,$visit_data)) {

      if(update_hits()) {
           echo "an error has occured! ".mysql_error();
           die();
      }
      else {
           $num_visit_data = count($visit_data);
           $next_visit_data_id = $num_visit_data + 1;

           setcookie("visit_data[$next_visit_data_id]",$this_page_id,$exp);
      }

 }

}

?>

I hope this gets you on your way. I tested it for you and it works just fine.

Chad.

[Anon]

This is what I did not sure if it's good but you tell me:

<?
if (!$id) {
header("Location: http://www.zealousgamers.com/reviews/");
} else {

// Count Once
if (isset($pagenum[$id])) {
} else {
$db_name = "db_zgamers";
$table_name = "reviews";
$connection = @mysql_connect("localhost", "zgamers", "***")
or die("Couldn't connect.");

$db = @mysql_select_db($db_name, $connection)
	or die("Couldn't select database.");

$replace = mysql_query("UPDATE $table_name SET hits=hits+1 WHERE id='$id'", $connection);
setcookie("pagenum[$id]", "yes", time()[phone], "/reviews", ".zealousgamers.com", 0);	

}

[inlandpac]

Overall it looks okay. I have made some very minor modifications below and annotated for you.

You should think about writing a class to take care of all of this so you don't have to populate your all of your scripts with this.

Lemme know if you desire to do that and need help.

<?php
if (!$id) {
/
NOT REALLY A GOOD IDEA TO USE FULL URIs TO RELOCATE WITHIN YOUR OWN SITE.
YOU CAN JUST USE THE RELATIVE OR ABSOLUTE PATH FROM DOCUMENT_ROOT
/
header("Location: /reviews/index.php");
}

if(!$pagenum[$id]) {
$db_name = "db_zgamers";
$table_name = "reviews";

 /**
   create PERSISTENT CONNECTION (NOTE THE pconnect VERSUS connect) connection
 **/
 $connection = @mysql_pconnect("localhost", "zgamers", "***") or die("Couldn't connect."); 

 /**
   select your database
 **/
 $db = @mysql_select_db($db_name, $connection) or die("Couldn't select database."); 

 /**
   update table (remember this UPDATES only work if a 
   row already exists with id field containing $id

   NOTICE IN THE SAMPLE I PROVIDED, I ALLOWED FOR INSERT AND OTHERWISE UPDATE TO
   GUARANTEE SUCCESS ONE WAY OR THE OTHER.

   NO NEED TO INCLUDE DB POINTER UNLESS YOU HAVE MULTIPLE DATABASES SELECTED
   WITH DIFFERENT POINTERS (WOULD NOT RECOMMEND IT)
 **/
 $replace = mysql_query("UPDATE $table_name SET hits=hits+1 WHERE id='$id'");

 /**
   set my cookie (accessible only in reviews directory 
   on zealousgamers.com with no security and expires in 31.3 years

   THE EXPIRATION DATE IS NOT ACTUALLY A VALID EXPIRATION DATE!  COOKIES DO 
   NOT LAST THIS LONG.  THEY USUALLY EXPIRE IN A MAXIMUM OF 1 YEAR 
   WHETHER YOU WANT THEM TO OR NOT.
 **/
 setcookie("pagenum[$id]", "yes", time()[phone], "/reviews", ".zealousgamers.com", 0); 

}
?>