crazy

Anon

can you all slap me wake? what is going on?? the first part works, then I do exactly the same, but in a function and that gives errors... going for some more coffee...
<xmp>Start of code:

<body>
<?

$file_dir= "D:/temp";
if (isset( $fupload ) ) {
echo $fupload;
copy ( $fupload, "$file_dir/$fupload_name") or die ("Could not copy");
echo "Upload OK!";
} else { print "

<h1>Upload Form</h1>
<form enctype=multipart/form-data action=upload.php method=post>
<input type=file name=fupload><br>
<input type=submit value=\"Send File\">
</form> ";
}

function upload($fupload) {
$file_dir= "D:/temp";
if (isset( $fupload ) ) {
echo $fupload;
copy ( $fupload, "$file_dir/$fupload_name") or die ("Could not copy");
echo "Upload OK!";
}
}
upload($fupload);

?>
</body>

end code</xmp>

Anon

Where does your function get the variable $fupload_name?

mharju

You have to declare the "fupload"-variable in the function.

i.e by using the keyword global
global $fupload;

or replacing the $fupload with $GLOBALS["fupload"];

🙂Mikko

Anon

I have no idea how that works, but without it, the filename isnt passed on, so Ill just leave it there 🙂

Anon

didnt work

heres the output:

C:\WINNT\TEMP\phpC6.tmpUpload OK!C:\WINNT\TEMP\phpC6.tmp
Warning: Unable to create 'D:/temp/': Permission denied in D:\Users\upload.php on line 23
Could not copy

mickro

belzebub,

I think the copy function only works in unix based systems

Mike

Anon

I guess you misunderstood me. See Mikko's comment. I was just drawing attention to the fact that your function doesn't know what $fupload_name is, and if the function doesn't declare it and you don't pass it in, it can't be used.

Anon

naah, it does work on windows the first time

Anon

oh yeah I see, now it works
thanks

and can you explain me where $fupload_name comes from?
I echoed both $fupload_name and $fupload and the result was first the filename and the second was the path and filename of the local tempory file
and since I dont declare $fupload_name it kinda upsets me, or is this some hidden php cool thingie 🙂 ?

Anon

It's a "hidden php cool thingie". Look up file uploads on www.php.net and you see the other variables that get set when you upload a file to PHP.